Skip to content

panel : remove special-casing of window-list - #597

Draft
AKArien wants to merge 2 commits into
WayfireWM:masterfrom
AKArien:fix-panel-allocation
Draft

AKArien wants to merge 2 commits into
WayfireWM:masterfrom
AKArien:fix-panel-allocation

Conversation

@AKArien

@AKArien AKArien commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Fix alignments to ensure widgets always have the desired shape and size

Fixes #595.

@mrsteve0924 I would appreciate if you could find the time to try break this ! Does it introduce any bugs i could not find ? And do you still experience your original issue with it ?

@mrsteve0924

mrsteve0924 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

ill give it a go.

Ok. been at it for an hour or so. i did get a repeatable seg fault. looks like it happens when swapping the window-list and command-output widgets between widgets-{left,center,right}. i am attaching the backtrace.
http://dpaste.com//3DC4UNS9P

The original issue i had is fixed with this patch. so when some setting is changed in wf-shell.ini the window-list will reload correctly.

2 behaviors I see that need addressing:

  • on dual monitors with full_span= false and center = false, my left display renders the panel correctly, but the right display seems to keep the panel expanded to the edges and some of the widgets in widgets_left and widgets_right are off-screen. if i set center = true, the panel on the right display reloads correctly.
fullspan-false;center-false-left;display fullspan-false;center-false;rightdisplay
  • when window-list is in widgets_center or widgets_left, as it expands when additional buttons are added it will encroach on the adjacent widgets_ box and shorten the text with ellipses. the current behavior in master doesnt do this and window-list will self-adjust instead.
ellipses-window-list-center ellipses-window-list-left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

widgets-left ignores center option when panel doesn’t span the full edge

2 participants