Repository navigation
Conversation
Contributor
|
ill give it a go. Ok. been at it for an hour or so. i did get a repeatable seg fault. looks like it happens when swapping the window-list and command-output widgets between widgets-{left,center,right}. i am attaching the backtrace. The original issue i had is fixed with this patch. so when some setting is changed in wf-shell.ini the window-list will reload correctly. 2 behaviors I see that need addressing:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix alignments to ensure widgets always have the desired shape and size
Fixes #595.
@mrsteve0924 I would appreciate if you could find the time to try break this ! Does it introduce any bugs i could not find ? And do you still experience your original issue with it ?