Skip to content

fix window-list in center pt 2 - #591

Open
trigg wants to merge 5 commits into
masterfrom
widgets-center-further
Open

fix window-list in center pt 2#591
trigg wants to merge 5 commits into
masterfrom
widgets-center-further

Conversation

@trigg

@trigg trigg commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

A few extra changes after #587

That PR was out of sync with master and the flow of layout alloc and measure had become quite convoluted.

mrsteve0924 and others added 4 commits November 8, 2026 11:00
@mrsteve0924 @trigg
panel: fix window-list alignment in the center section
95067a7 
Disable window-list expansion in the center section so its buttons remain centered as other panel widgets are added or removed.

Signed-off-by: stephen finkel <mrsteve0924@verizon.net>
Assisted-by: ChatGPT:GPT-5.6 Sol
@mrsteve0924 @trigg
window-list: size buttons to their content
887b4c4 
Measure each button individually and use window_list_size as the maximum preferred width. Account for unequal widths during allocation and request remeasurement when the size setting changes.

Add right padding to window titles to balance the existing left padding.

Signed-off-by: stephen finkel <mrsteve0924@verizon.net>
Assisted-by: ChatGPT:GPT-5.6 Sol
@trigg
panel: window-list: simplify layout calculations with orientation in …
adf8fa8 
…mind
@trigg
chore: remove old includes from window-list layout
4a13198
@mrsteve0924

mrsteve0924 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

was this because of the merge conflicts that came about after merging #585 or were my changes just a mess? :)

@trigg

trigg commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

The out of sync was because of merge conflicts, but the convoluted state is just a collection of changes over time I kept meaning to come back and make more readable.

The branches in measure were becoming difficult to follow and reason through, for example, so I (hopefully) made it more clear what is being measured.

@mrsteve0924

mrsteve0924 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

#587 (comment)

just an FYI for visibility...
i stumbled upon the center panel option that when set to true is supposed keep widgets centered when placed in widgets_center. seems like this one option is exactly what this PR is trying to fix. However, I tried and it does center widgets but with window-list it turns them into small dots or maybe just rendering the text very small?

2026-11-10_21:18:21

@AKArien AKArien mentioned this pull request Nov 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trigg @mrsteve0924