Repository navigation
Conversation
Collaborator
Author
Collaborator
Author
|
For anyone curious, my testing showed that GTK handles CSS incorrectly if you're adding multiple stylesheets at the same priority. It loops over each style sheet at the same priority but doesn't merge them, instead takes the matching values from the last-added stylesheet that has a match at all. So The fix is to merge all the CSS Config classes into one style sheet and update it all together, forcing CSS specificity to be respected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So initially we can fix this by moving the default rule sooner, but this needs more specificity to ensure it doesn't creep back.
For now, proof of point