Repository navigation
Conversation
1dfb89a to
0e3b360
Compare
0e3b360 to
848161c
Compare
848161c to
182f702
Compare
De-duplicates logic using a mixer singleton, not unlike the wireplumber mixer. This serves to share the gvc handling code between the locker and the panel. The interface is generic enough to allow for new features : - `volume` panel widget now presents a toggle to mute/unmute - `microphone` « widget », which is a sub-configuration of `volume` with which it shares it’s configuration. - The locker can now control volume instead of just un/muting, by virtue of re-using the same widget as the panel. This approach also helps a potential de-coupling of the audio control widgets from a sound server, at least for allowing `volume` to work natively on pw/wp.
|
I might add the reasoning on locker not having sliders was because lockscreens couldn't have popover widgets due to windowing restrictions in the lockscreen protocol. I don't know the current state, only mentioning incase it is still pertinent. |
Currently, this simply has the full slider in the lock screen, but it could also be hidden behind a revealer. |
Based on #532, which is itself based on #531
De-duplicates logic using a mixer singleton, not unlike the wireplumber mixer.
This serves to share the gvc handling code between the locker and the panel. The interface is generic enough to allow for new features :
volumepanel widget now presents a toggle to mute/unmutemicrophone« widget », which is a sub-configuration ofvolumewith which it shares it’s configuration.This approach also helps a potential de-coupling of the audio control widgets from a sound server, at least for allowing
volumeto work natively on pw/wp.