Repository navigation
Correct the secret scan comments merged in #36 - #42
Open
feinburger244 wants to merge 1 commit into
Open
feinburger244 wants to merge 1 commit into
feinburger244 wants to merge 1 commit into
Conversation
.gitleaksignore said both allowlisted Healthchecks keys had been removed, and secret-scan.yml said gitleaks-action needs a paid license and that the scan covers the whole history. All three were wrong. The keys were compared by sha256 against each source; no value was printed. - bd9c129's key was rotated on 2025-10-30. infra-config 3e4996f3be replaced it in secrets/secrets.yml after Prometheus started getting 403s, and WATonomous/status#83 removed it there. - 03293f2's key is infra-config's current healthchecksio_readonly_api_key (hcr_ prefix, read-only). It is still in internal/status/status.go on release/v1.4 and in tags v1.0 to v1.4.1, so the deployed v1.4.1 binary embeds it. WATonomous/watcloud-website (scripts/generate-website-config.py, sent from the browser by components/machine-card.tsx) and WATonomous/status (src/constants.ts) publish it. The key is not rotated here. Rotating it would break the website, the status page, Prometheus and `watcloud status` in v1.4.x, and the website would go on publishing the new key. #36 closed #6, whose first point asks for rotation, so whether to rotate is still open. The gitleaks-action README says organizations need a free license key, obtained by signing up. gitleaks v8.28.0 runs `git log -p -U0 --full-history --all --diff-filter=tuxdb` (sources/git.go), and actions/checkout with fetch-depth: 0 fetches every branch and tag. So every run scans all of them, and without -m it skips changes made in merge commits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36 merged comments that are wrong about the allowlisted Healthchecks keys and about gitleaks-action.
.gitleaksignoresaid both keys had been removed.internal/statusonrelease/v1.4, in tags v1.0 to v1.4.1 and in the deployed v1.4.1 binary. WATonomous/watcloud-website and WATonomous/status publish it too.secret-scan.ymlsaid gitleaks-action needs a paid license and that the scan covers the whole history.Refs #6. #36 closed it, but #6's first point, rotating the key, hasn't been done.
To make the check required, add
gitleaksas the required status check formain. #36 gave the name asSecret scan / gitleaks, which is the workflow and job name together, not the check's name.🤖 Generated with Claude Code