Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple issues I found while testing visor with photon shaders.
One was odd temporal behavior both with and without per-eye pipelines enabled. This was caused by the frame count / timer syncing accidentally being turned off when per-eye pipelines was on, causing each eye to have different temporal references. Fixed by keeping the syncing always on.
The second issue was the player model shadow appearing as if it was below the ground level rather than correctly rendering at the surface. This was due to the model position being transformed for per-eye camera use even when iris requests the entity position of the player model. Fixed by injecting a swap during the extraction call so it is positioned correctly for the shadow pass.
With these small tweak visor is performing about as well as I could ask for with photon, it's really quite impressive!