Skip to content

Recover iPhone trust diagnostics after closed startup timeouts - #525

Open
BunsDev wants to merge 2 commits into
mainfrom
ios-trust-bootstrap
Open

BunsDev wants to merge 2 commits into
mainfrom
ios-trust-bootstrap

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

PR #524’s first paired iPhone failure retained a request timeout while certificate-chain trust evaluation had no observed return. Its diagnostic observer exited on an initial five-second simulator metadata timeout before collecting stacks. This repair retries only confirmed-closed startup metadata timeouts, for at most three sequential reads with the same five-second/one-MiB bounds and existing overall observer deadline.

Cancellation, malformed metadata, wrong device, non-timeout errors and unknown child closure still stop startup. Fixed typed attempt receipts retain no raw output or private error strings. App/process/thread/activity/trustd identity guards and the common cleanup refusal remain intact.

The shell unit fixture now distinguishes an acknowledged Xcode failure from missing observer readiness within a shared monotonic seven-second budget; existing eight-second parent and ten-second test bounds and helper lifecycle assertions remain. Controlled delayed/missing acknowledgement cases failed before the fix. The original full-root failure’s exact timing cause remains unproven and its logs are retained.

Validation: 44 focused controls pass with zero failures/skips. Scoped independent review is clear after correcting a short negative-case allowance. Frozen build and typechecks pass, and full units report 2,607 passes with 36 skips and zero failures/cancellations at signed 7f8b05ece464e44a23b427ccbdb49f3a4435d182; the source manifest is unchanged. The first full-root build/typecheck passed but its unit fixture failed; that failure remains recorded separately.

This is diagnostic recovery for #109/#281. Trust APIs, pins, request deadlines and pairing outcomes are unchanged. Fresh hosted collection and causal stacks remain required; a later successful pairing alone does not prove a trust-stall repair. Physical-phone, older-Companion, two-network, human, release and activation gates remain open. See docs/reviews/2026-11-13-ios-trust-bootstrap.md.

Hosted qualification now passes in source run 43559871989. Its actual preview e52e8ceda2e2c9f994dc7e69f2fbbb0e9dd69173 has parents 538d3573 and 7f8b05e; tree 883e131b35dc2e2ae9aaf7f01fc924ec1afb604e matches an independent clean merge projection. Raw logs show 2,871 unit passes with 36 skips, 549 desktop E2E passes with 14 skips, eight site passes and four web passes, with zero failures/cancellations or observed retries. All four artifacts pass GitHub size/digest and ZIP integrity checks. This preview includes newer main changes; its tree is distinct from the bare source head.

The independent iPhone artifact retains 65 native passes and 43 ordinary paired passes plus one expected-failure control, with zero actual failures/skips. The diagnostic manifest confirms the device on its first startup query, then stops with COMMAND_CLEANUP_UNVERIFIED and no samples. Thus hosted pairing passes and startup confirmation are demonstrated, while causal stack collection and the original trust-stall repair remain unqualified. Protected queue delivery and all human/device/release gates remain separate.

Bound simulator metadata startup to three confirmed-closed timeout attempts while preserving cancellation, device identity and command cleanup refusal. Retain the original paired trust failure without changing application policy or test outcomes.
Distinguish fixture readiness expiry from the intended Xcode exit, retain bounded helper cleanup and cover delayed and missing acknowledgements. Preserve first full-root failure and uncertainty about its original timing cause.
@vercel

vercel Bot commented Nov 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 14, 2026 5:06am UTC
modex-app Ready Ready Preview Nov 14, 2026 5:06am UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 538d357 ios-trust-bootstrap 7f8b05e +/-
66% 66% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev added this pull request to the merge queue Nov 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 14, 2026
@BunsDev

BunsDev commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

The first protected queue run for source 7f8b05ece464e44a23b427ccbdb49f3a4435d182 failed at queue head 81fec064c5ef70ecd8dd827de3811871d2ef1dd6. The required macOS job reached 548 desktop E2E passes, 14 skips and one failure: “CR-4 to CR-7 text meets AA contrast in the Jev theme” timed out clicking Settings, then teardown timed out. The queue’s iPhone job was skipped. This PR remains unmerged; the earlier successful source CI and iPhone results remain source qualification, not a protected queue pass.

The preserved Electron stderr records an uncaught write EPIPE in CodexBackend.send, and its process sample shows an NSAlert modal loop. Separate synthetic probes against the actual backend reproduce unhandled stdin EPIPE during initialization and an active turn’s Stop request using a real subprocess pipe; no live provider or installed user session was involved. This identifies a transport error-handling gap; the exact queue timing remains unproven. Both uploaded artifact ZIPs were checked against their API digests and retained with the original log and trace. I have not retried or requeued this PR. The transport repair will preserve uncertain approval delivery and require confirmed process lifecycle handling before another queue attempt.

This branch was successfully deployed

1 active deployment
Preview – modex — 7f8b05ec Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant