Repository navigation
Deflake GPU-badge re-send test: settle the probe thread first - #175
Merged
Merged
Conversation
QuantUIApp starts a background quantui-gpu-detect thread at construction that sets _status_html.value when it finishes. When that landed after the test had patched send_state, it recorded an extra "value" send and test_settings_tab_resends_the_badge failed (~1 in 3 when run alongside the viewer test files). Give TestB1GpuBadge its own app fixture that stubs gpu_offload.probe_gpu (instant, hardware-independent) and joins this app's detect thread before the test patches send_state. App behaviour is unchanged; the test still fails if the Settings tab stops re-sending. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017NANrpr6Ez2krGCpnwM4yW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuantUIApp starts a background quantui-gpu-detect thread at construction
that sets _status_html.value when it finishes. When that landed after the
test had patched send_state, it recorded an extra "value" send and
test_settings_tab_resends_the_badge failed (~1 in 3 when run alongside the
viewer test files).
Give TestB1GpuBadge its own app fixture that stubs
gpu_offload.probe_gpu (instant, hardware-independent) and joins this
app's detect thread before the test patches send_state. App behaviour is
unchanged; the test still fails if the Settings tab stops re-sending.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017NANrpr6Ez2krGCpnwM4yW