Skip to content

ci: remove redundant settings - #430

Open
lachlancollins wants to merge 2 commits into
mainfrom
remove-redundant-options
Open

lachlancollins wants to merge 2 commits into
mainfrom
remove-redundant-options

Conversation

@lachlancollins

@lachlancollins lachlancollins commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

These options are the defaults, so it's unnecessarily verbose.
See https://github.com/voidzero-dev/setup-vp#inputs

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated the automated autofix, pull request, and release workflows to use the setup action’s default configuration rather than explicitly setting installation and caching options.
    • These changes affect workflow setup only; no user-facing product behavior or functionality has changed.

@lachlancollins
lachlancollins requested a review from a team as a code owner November 2, 2026 22:40
@changeset-bot

changeset-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c3c681e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4e9ea065-b346-4473-8c7e-62a7b1d7feef
Commits

Reviewing files that changed from the base of the PR and between e25ab47 and 102a41f.

Files selected for processing: 3
  • .github/workflows/autofix.yml
  • .github/workflows/pr.yml
  • .github/workflows/release.yml
Files with no reviewable changes: 3
  • .github/workflows/release.yml
  • .github/workflows/pr.yml
  • .github/workflows/autofix.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The autofix, PR, and release workflows no longer explicitly configure installation or caching in their Vite+ setup steps.

Changes: Vite+ setup workflows

Layer / File(s) Summary
Remove explicit setup options
.github/workflows/autofix.yml, .github/workflows/pr.yml, .github/workflows/release.yml
The Vite+ setup steps no longer pass run-install: true or cache: false.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Suggested reviewers: schiller-manuel

Merge Risk: Minimal · up to 102a4

The workflow cleanup preserves installation and caching behavior and is ready to merge after normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: removing redundant CI settings.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description includes all required sections. It explains the change and motivation, confirms both checklist items, and identifies the change as CI-only with no release impact.
Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nx-cloud

nx-cloud Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 102a41f

Command Status Duration Result
nx affected --targets=test:sherif,test:docs,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-11-02 23:01:16 UTC

@pkg-pr-new

pkg-pr-new Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@tanstack/eslint-config@430
npm i https://pkg.pr.new/@tanstack/publish-config@430
npm i https://pkg.pr.new/@tanstack/typedoc-config@430
npm i https://pkg.pr.new/@tanstack/vite-config@430

commit: c3c681e

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant