[datlechin]

Summary

• One license presentation, LicensePresentation, under every license surface. Each state has one title, one message and one action (LicenseNoticeAction: Activate License…, Renew License, Buy a License, Upgrade Plan, Try Again).
  • gate(for:access:): no license names the plan and offers Activate License… (the dialog carries the purchase link); a plan the license lacks offers Upgrade Plan; expired, suspended and unverified reuse the License pane's own notice, so a paying customer is never asked to buy.
  • ProFeatureAccess gains .suspended, which used to fold into .unlicensed.
  • Rendered by the gate overlay (Query Insights, Result Charts), the Compare & Sync and Data Rewind alerts (LicenseGateAlert), a LicenseGateRow in Settings (Sync, Linked Folders, Data Rewind) and the connection export sheet, the License pane, and Welcome.
  • The orange PRO capsule (ProBadge) is gone.
• A failed license check now shows. LicenseManager.checkFailure holds a check that reached no verdict (offline, server error); every Try Again shows a spinner while it runs and the reason under it after; Refresh shows it under the plan line. Checks coalesce, and an answer for a license deactivated or replaced during the check is dropped.
• Welcome:
  • the license line renders the License pane notice as a link, expiring soon included; renew opens the pricing page, Could Not Check This License opens Settings > License and checks again, suspended and removed open the pane; no license keeps Activate License;
  • a sync blocker (storage full, signed out, data removed, update required, restricted, unavailable) shows its title as a link to Settings > Sync;
  • the Black Friday line is unchanged and still shows only to people without a working license.
• One sync presentation, SyncStatusPresentation in TableProSyncTransport, used by both apps: titles, symbols and actions (SyncStatusAction). Each app keeps only its sentences (this Mac, this device) and handlers; iOS drops the three actions it has no public way to perform.
• Sync pane (macOS):
  • a blocker's notice carries its Try Again, and Sync Now leaves the status section while a blocker stands, so restricted, update required and unavailable no longer offer a retry that cannot help;
  • license states render the gate row under the switch instead of a "Sync Paused" notice;
  • SyncCoordinator.evaluateStatus reads the switch before the license, so sync that was never turned on is off by choice.
• Doc blocks cleared in the files touched.

Defect on main	Fixed by
Gates told an unverified (offline 30 days) or suspended customer to buy: "Compare & Sync requires the Pro plan", "Data Rewind needs a Pro license / Purchase License", PRO capsule to pricing, "needs a Pro license" in Data Rewind settings	gate(for:access:), .suspended access
Each gate wrote its own text; the overlay said "License validation failed / Retry Validation", the pane "Could Not Check This License / Try Again"	One presentation
Welcome offered Activate License to expired, suspended and removed licenses, showed an orange tier name with only a tooltip for an unverified one, and never showed License Expiring Soon	welcomeLine
A failed license check showed nothing; Try Again, Check Again, Retry Validation and Refresh re-enabled with no change offline	checkFailure, LicenseCheckFailureLine
Try Again and Retry Validation could start a second check while one ran; an answer arriving after Deactivate restored the license	Coalesced checks, adoptsValidation
Storage full, signed out, data removed and update required showed only in Settings > Sync on macOS	Welcome sync line
macOS and iOS sync copies drifted: signed out offered Open System Settings vs Try Again; not ready, restricted and unavailable had different symbols; Turn Off Sync vs Turn Off iCloud Sync	Shared presentation
Sync Now offered for restricted, update required and unavailable	offersSyncNow
A suspended license showed only the PRO capsule in the Sync pane; an expired one showed "Sync Paused" even with sync never turned on; the license branches of statusTitle were unreachable	Gate row, switch read first, license branches removed
The gate overlay did not observe the license manager	@ObservedObject

Decisions taken without a design review:

• Welcome performs the notice's action when its outcome is visible (sheet, browser) and opens Settings > License otherwise, since Welcome has no room for a check's result.
• A gate with no action (suspended) opens Settings > License instead of an alert that only informs.
• Settings rows use a plain form row (title, secondary message, trailing action), not a badge.
• Sync symbols follow the macOS set; "Turn Off iCloud Sync" names the feature on both apps.
• iCloud Is Not Ready stays off Welcome: it clears itself.

Tests changed on purpose, because they pinned the old shape:

• LicenseTierTests.inactiveStatusesReportUnlicensed (suspended moved to suspendedReportsSuspended);
• LicensePresentationTests.lapsedLicenseMarksNothing (suspended access);
• macOS SyncStatusPresentationTests.storageFullAction, removedDataOffersAChoice (Try Again in the notice, Sync Now hidden for blockers);
• iOS SyncStatusPresentationTests (mobileActions).

Test plan

• New suites and cases:
  • package SyncStatusPresentationTests (7);
  • macOS: gate, Welcome line and check failure cases in LicensePresentationTests, LicenseManagerDecisionTests (checkFailureIsOnlyANonVerdict, validationAnswersOnlyForTheCheckedLicense), LicenseTierTests.suspendedReportsSuspended, SyncCoordinatorArmingTests.offWithoutALicenseIsOffByChoice, SyncStatusPresentationTests (Sync Now, license states, Welcome);
  • iOS SyncStatusPresentationTests.macOnlyActionsAreDropped.
• Package TableProSyncTests sync suites: 17 of 17.
• macOS license and sync suites (18 suites, every type touched): 204 executed; the one failure was lapsedLicenseMarksNothing, updated above; rerun of the license suites after the race fix: 104 of 104.
• iOS: SyncStatusPresentationTests 6 of 6, ConnectionListStateTests and IOSSyncCoordinatorTests 69 of 69.
• macOS Unit plan on this branch (main had not moved): 28,417 passed, 0 failed, 2 skipped.
• Lint on 30 changed Swift files: 0 violations. verify.sh l10n: pass on both catalogs. The iOS catalog change is inserted in place (66 lines), not a re-sort.
• Codex: an adversarial round found overlapping checks could restore a deactivated license (fixed: coalesced checks, stale answers dropped); a second round against origin/main found nothing.
• Not verified:
  • a real license server answer; the check outcomes are covered by decision tests and seeded screenshots;
  • a live CloudKit blocker; the Welcome and Sync pane shots use a seeded status;
  • macOS 13 to 15 and iOS 18 to 25.

Screenshots

States other than "no license" are seeded through a temporary patch that is not in this PR: a signed-looking license issued 63 days ago (so it resolves to not checked), a failed check, and a forced storage full status with sync on. Before is origin/main at ef25ea7 with the same patch.

	Light	Dark
Before: Welcome, license not checked in 30 days, orange tier name, tooltip only
After: link to Settings > License that checks again
Before: Settings > Sync, license not checked in 30 days, PRO capsule to pricing
After: row with Try Again and the failed check
Before: Settings > Data, Data Rewind, license not checked, "needs a Pro license"
After: the same row
Before: Compare & Sync, license not checked, "requires the Pro plan" / View License
After: the license notice / Try Again
Before: Query Insights overlay, license not checked, "License validation failed" / Retry Validation
After: the license notice, Try Again and the failed check
Before: Settings > Sync, no license, PRO capsule
After: row naming the plan with Activate License…
Before: Welcome, iCloud storage full, nothing
After: link to Settings > Sync
Before: Settings > Sync, iCloud storage full, Manage Storage… in the notice, Sync Now below
After: Manage Storage… and Try Again in the notice, no Sync Now

iOS 26 (iPhone 17 Pro simulator; the real views in a window)

	Light	Dark
Before: Connection list, iCloud not ready, icloud.slash
After: exclamationmark.icloud, as on the Mac
Before: Empty list, iCloud restricted, icloud.slash
After: xmark.icloud, as on the Mac