Repository navigation
Support server-owned vehicles (VF 2.20.0) - #248
Conversation
Server conversion releases the payer and clears pending offers, upkeep requests, fee prompts, unpaid maintenance and click modes. Fee, upkeep, handover and transfer flows skip server vehicles. In campaign battles a server vehicle is usable only by the forced side or when all vehicles are usable. The ServerVehicleUseEvent listener is registered only when VF has it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
ConfigLoaderBattleScheduleTest loads configs that set static Cache fields such as warAvailabilityTimeLockHours=12 and never put them back, so war schedule tests that ran after it computed time locks from the wrong settings. Main's build has failed on this since 2026-11-14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Supports server-owned vehicles from VehicleFramework v2.20.0 (
/vf server, VF PR #95). A server vehicle has no player owner, no payer and no upkeep. SimpleFactions now treats it that way.Conversion
/vf serverchanges ownership (reasonSERVER), the gate releases the vehicle through the normalforgetOwnerpath: the payer row is dropped and the change is audited.STAFF_VEHICLE_SERVERlog line records the staff member, the vehicle, the previous owner and the previous mode./vf takeoveruses the normal takeover path and restores a payer.Battles
ServerVehicleUseListeneranswers VF'sServerVehicleUseEventwith these rules. It is the only class that references the event. It is registered only afterClass.forNamefinds the event, so SF still loads on older VF.Audit
These flows skip server vehicles:
The reconcile reports a server vehicle that still has a payer row.
Other
vehicleframework.versionis now 2.20.0.OwnerTags.SERVERandVehicleRemovals.isServerwere added.Tests
ServerVehicleAuditTestandServerVehicleUseTest.mvn verifypasses with 100% line coverage.🤖 Generated with Claude Code