Repository navigation
Mage weapons follow their template's classes and two-handed flag - #80
Conversation
…efresh Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
|
@coderabbitai review |
Action performed
|
Status record
Left alone from the review:
isOutdatedcompares the final class tag whileapplysets the original layer of a class stat history, so a weapon whose history added a class would rebuild on every touch. No Mage weapon can get there today (runes carry no classes and every template now lists classes).Why
Mage is getting three weapon paths (ServerAssets PR): the staff, wand and blade templates list Invoker, Conjurer and Battlemage instead of Mage. A crafted mage weapon is rebuilt from its own data on refresh, so weapons players already hold would keep
required-class: Mage. Nobody could use them after the change. Handedness is synced the same way: Main's crafted blade template stops being two-handed, so crafted blades held today become one-handed on their next refresh.What
GearTemplateSync: a weapon is outdated when its classes (as a set, ignoring case) or its two-handed flag differ from its MMOItems template. A refresh then copies only those two stats from the template. With a class stat history only its original layer changes; a template without classes or two-handed removes them.GearRefreshertreats that as one more reason to rebuild, and applies the sync while rewriting. Sockets, runes, part stats, name, skin and requirements are carried as before.Not in this PR
No release, nothing on Main or Tutorial.
🤖 Generated with Claude Code