Repository navigation
tune: ingredients keep a week, soup and sauce three days - #127
Merged
Merged
Conversation
Owner rule (2026-11-13): raw ingredients last at least a week before they turn Stale, and cooked soup and sauce go from 2 to 3 days. age.freshness is days until Stale (Rotten at 1.25 times that): milk_bucket and cup_of_milk 0.5 -> 7, dough 1 -> 7, yeast 4 -> 7, egg 4 -> 7, soup 2 -> 3, sauce 2 -> 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
XxFran10xX
marked this pull request as ready for review
November 13, 2026 23:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status record
ShelfLifeDefaultsTest,FoodItemCoverageTest,AgeScaleTest,EggIngredientTest). The full localmvn verifyran 1,547 tests with 4 failures, all Windows CRLF failures in tests that readmodels.ymland ItemsAdder files. They don't touch these values; Linux CI decides.What changes
Owner rule (fran, 2026-11-13): ingredients should last at least a week, and cooked soup and sauce go from 2 to 3 days.
age.freshnessintypes.ymlis the number of days until a food turns Stale. Rotten comes at 1.25 times that (tags.ymlfreshness: stale 86400 s, rotten 108000 s at multiplier 1).milk_bucket(Milk)cup_of_milkdoughyeasteggsoupsauce"Milk" covers both milk types, the bucket and the cup, which had the same 0.5.
tags.ymlis unchanged because the multiplier is set per type intypes.yml. The newShelfLifeDefaultsTestpins these values in the shipped defaults.Every type under 7 days (shipped default and live Main)
seasoning_1,sweetener_1,honeyupdate: false)yeast,dough,egg,milk_bucket,cup_of_milksoup,sauceboiled_ricefried_rice,rice_pudding,sushi,hot_chocolateLive Main lists only the first three rows. Its
types.yml(identical to Tutorial's) has no rice, sushi or hot chocolate types yet. No other raw ingredient is under 7 days. No origin override sets freshness under 7. Dev-only ingredient typestree_sap(0.5),stock(2),paste(5) andjuice(4) are not in the bundled defaults or on Main; they will need the week rule when they ship.Live configs (not in this PR)
Cooking never overwrites an existing config, so each server needs an in-place edit of
plugins/Cooking/types.ymland thencooking reload. I read Main and Tutorial: the seven entries match the repo defaults exactly (Main and Tutorialtypes.ymlare byte-identical), so the live edit is the same seven-line diff. Dev'stypes.ymlis an older test copy with different values (e.g. dough 0.5, egg 1, soup/sauce unset).Existing food keeps its stored age and ages more slowly from its last age update on.
FoodItem.updateAgeadds all the time since that item'slastUpdate, divided by the type's current multiplier, so time that has passed but not yet been applied also counts at the new, slower rate. Stale items stay Stale; they don't become Fresh again.Wiki
No wiki change. The Gameplay Guide's cooking page ("Keeping food fresh") says only that "Shelf life varies by food" and gives no numbers. A grep of
frontend/app/wikifor shelf life, stale or rotten values found nothing for food (the brewing page's day counts are brew aging, not food).🤖 Generated with Claude Code