Skip to content

tune: ingredients keep a week, soup and sauce three days - #127

Merged
XxFran10xX merged 1 commit into
mainfrom
tune/shelf-life-week-ingredients
Nov 13, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
tune/shelf-life-week-ingredients

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Status record

  • Reviewed: Fable 5.2 APPROVE at 0dc73bf
  • Dev-tested: passed at 0dc73bf (TFMCDev01, 2026-11-13: bot FbCook1; dough, cup of milk, milk bucket, egg, yeast, soup and sauce back-dated 3.5 days aged to freshness 43,199-43,200 at multiplier 7 (Fresh) and 100,799 at multiplier 3 (Stale), as expected)
  • Local tests: passed at 0dc73bf (ShelfLifeDefaultsTest, FoodItemCoverageTest, AgeScaleTest, EggIngredientTest). The full local mvn verify ran 1,547 tests with 4 failures, all Windows CRLF failures in tests that read models.yml and ItemsAdder files. They don't touch these values; Linux CI decides.

What changes

Owner rule (fran, 2026-11-13): ingredients should last at least a week, and cooked soup and sauce go from 2 to 3 days.

age.freshness in types.yml is the number of days until a food turns Stale. Rotten comes at 1.25 times that (tags.yml freshness: stale 86400 s, rotten 108000 s at multiplier 1).

Type Before (Stale / Rotten) After (Stale / Rotten)
milk_bucket (Milk) 0.5: 12 h / 15 h 7: 7 d / 8.75 d
cup_of_milk 0.5: 12 h / 15 h 7: 7 d / 8.75 d
dough 1: 1 d / 1.25 d 7: 7 d / 8.75 d
yeast 4: 4 d / 5 d 7: 7 d / 8.75 d
egg 4: 4 d / 5 d 7: 7 d / 8.75 d
soup 2: 2 d / 2.5 d 3: 3 d / 3.75 d
sauce 2: 2 d / 2.5 d 3: 3 d / 3.75 d

"Milk" covers both milk types, the bucket and the cup, which had the same 0.5. tags.yml is unchanged because the multiplier is set per type in types.yml. The new ShelfLifeDefaultsTest pins these values in the shipped defaults.

Every type under 7 days (shipped default and live Main)

Type freshness Kind This PR
seasoning_1, sweetener_1, honey not set (update: false) ingredient none: these never age
yeast, dough, egg, milk_bucket, cup_of_milk 4, 1, 4, 0.5, 0.5 raw ingredient changed to 7
soup, sauce 2 cooked dish changed to 3
boiled_rice 4 cooked (also goes into fried rice, rice pudding and sushi) none; not on Main yet
fried_rice, rice_pudding, sushi, hot_chocolate 4, 2, 2, 2 cooked dish / drink none; not on Main yet

Live Main lists only the first three rows. Its types.yml (identical to Tutorial's) has no rice, sushi or hot chocolate types yet. No other raw ingredient is under 7 days. No origin override sets freshness under 7. Dev-only ingredient types tree_sap (0.5), stock (2), paste (5) and juice (4) are not in the bundled defaults or on Main; they will need the week rule when they ship.

Live configs (not in this PR)

Cooking never overwrites an existing config, so each server needs an in-place edit of plugins/Cooking/types.yml and then cooking reload. I read Main and Tutorial: the seven entries match the repo defaults exactly (Main and Tutorial types.yml are byte-identical), so the live edit is the same seven-line diff. Dev's types.yml is an older test copy with different values (e.g. dough 0.5, egg 1, soup/sauce unset).

Existing food keeps its stored age and ages more slowly from its last age update on. FoodItem.updateAge adds all the time since that item's lastUpdate, divided by the type's current multiplier, so time that has passed but not yet been applied also counts at the new, slower rate. Stale items stay Stale; they don't become Fresh again.

Wiki

No wiki change. The Gameplay Guide's cooking page ("Keeping food fresh") says only that "Shelf life varies by food" and gives no numbers. A grep of frontend/app/wiki for shelf life, stale or rotten values found nothing for food (the brewing page's day counts are brew aging, not food).

🤖 Generated with Claude Code

Owner rule (2026-11-13): raw ingredients last at least a week before
they turn Stale, and cooked soup and sauce go from 2 to 3 days.
age.freshness is days until Stale (Rotten at 1.25 times that):
milk_bucket and cup_of_milk 0.5 -> 7, dough 1 -> 7, yeast 4 -> 7,
egg 4 -> 7, soup 2 -> 3, sauce 2 -> 3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4abe5940-b23c-4ae3-a34e-f5985ca312f4
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Nov 13, 2026
@XxFran10xX
XxFran10xX marked this pull request as ready for review November 13, 2026 23:01
@XxFran10xX
XxFran10xX merged commit d1d7563 into main Nov 13, 2026
4 checks passed
@XxFran10xX
XxFran10xX deleted the tune/shelf-life-week-ingredients branch November 13, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant