Skip to content

Minor improvements & bug fixes - #375

Open
Laveig wants to merge 8 commits into
StrataSource:masterfrom
Laveig:master
Open

Laveig wants to merge 8 commits into
StrataSource:masterfrom
Laveig:master

Conversation

@Laveig

@Laveig Laveig commented Nov 14, 2026

Copy link
Copy Markdown

List of changes:

  • Added missing FGD entries to env_fire
  • Renamed important KVs in color_correction for better understanding what they do
  • Fixed logic_random_outputs bug (see this)
  • disableflashlight now has correct description
  • Renamed Disable ShadowDepth to Disable Clustered Shadows for better understanding what this KV does

Laveig and others added 6 commits September 3, 2026 20:53
- Moved important keyvalues higher, highlighted certain areas with line dividers.
- Changed weird names and descriptions.

Generally made some entities more convenient to use. Personally, I often find myself looking for keyvalues that are at the end of the list or just hidden among other KVs, this PR attempts to fix this issue.
@crazy-hair

Copy link
Copy Markdown

I don't believe the lighting keyvalues changed here are accurate descriptions, they should behave similarly to how they work in the base game, just updated to have clustered terminology instead of ptex terminology:
image

@lenship2

Copy link
Copy Markdown

flashlights still use the same rendering as any other dynamic light, the disableflashlight name just seems to be leftover terminology from when the flashlight was the only thing projected textures were associated with. so, ideally, disableflashlight would effectively disable clustered itself rendering on an object entirely (hence the current description). although im not sure whether that function actually works in strata right now or not...

@lenship2
lenship2 self-requested a review November 17, 2026 02:46

@lenship2 lenship2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes seem good (the logic_random_outputs and env_fire kvs are especially helpful), but the clustered terminology should be changed I think

Comment thread fgd/bases/BaseEntityAnimating.fgd Resolved
Comment thread fgd/bases/BaseEntityAnimating.fgd Resolved
@crazy-hair

crazy-hair commented Nov 17, 2026 •

Copy link
Copy Markdown

I also don't think that the Color Correction changes are accurate, 'weight' and 'lookup table' are the proper technical terms for color correction, and 'opacity' doesn't make much sense here since it's not a transparent effect. 'intensity' would be more accurate, if you think weight is too confusing (I personally would keep the KVs the same and just update the descriptions if you want to make it a little more accessable). I'm also not entirely sure why you removed the disclaimer that only one could be exclusive at a time, that seems useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants