Skip to content

修复:恢复音量和亮度快捷键的 OSD 动画 - #22

Open
xiaoyu1738 wants to merge 4 commits into
StatIndet:mainfrom
xiaoyu1738:fix/media-key-osd-bindings
Open

xiaoyu1738 wants to merge 4 commits into
StatIndet:mainfrom
xiaoyu1738:fix/media-key-osd-bindings

Conversation

@xiaoyu1738

@xiaoyu1738 xiaoyu1738 commented Nov 8, 2026 •

Copy link
Copy Markdown

变更内容

  • 让亮度快捷键通过 Clavis 的 Brightness 服务调节,使 Keystone 能收到亮度变化并显示 OSD 动画。
  • 让音量增加、音量减少和静音快捷键通过 Clavis 的 Volume 服务调节,保留设备错误处理和 100% 音量上限。
  • 为默认 Niri 配置添加音量、静音和亮度 XF86 快捷键绑定。
  • 将 5 个媒体动作加入快捷键动作目录,使它们即使未绑定也会显示在设置页中,并提供“添加快捷键”入口。
  • 补齐英文、简体中文和繁体中文动作名称。
  • 补充 Quickshell.Io 导入,避免注册音量 IPC 后导致 QML 启动失败。
  • 补充配置契约测试。

验证

  • python3 -m unittest tests/test_niri_config.py -v(41 项通过)
  • scripts/dev/check.sh(通过;QML lint 报告 13 条 advisory warning)
  • 翻译 XML 校验通过
  • niri validate -c /home/fish/.config/niri/config.kdl(通过)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T13:36:42.502454Z 5dd75ac New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 179bfbc06f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/system/niri_config.py Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84d4992b77

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Common/NiriActionNames.js Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5dd75ac0ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Services/Volume.qml Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant