Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
After CS2 Nov 11, 2026 Update, MultiAddonManager crashes the server on the first message it sends to a client. The new signatures don't fix this, because the signatures aren't the cause.
When it happens
CServerSideClientBasehook sees every message sent to a client.AddClientAddonwith a refresh throughIMultiAddonManager, which crashes inGetAddonSignonStateMessage.Cause
The update changed the network message system but kept the name
NetworkMessagesVersion001:GetNetMessage()->GetNetMessageInfo()makes a virtual call on that record and crashes.FindNetworkMessagePartialmoved from index 14 to 10, andAllocateMessagewas removed.GetAddonSignonStateMessageuses both.Fix
All in
src/multiaddonmanager.cpp:pData->GetMessageId(). Its index is unchanged and it returns a constant.AllocateNetMessagehelper looks up the type through index 10, checks the name, and calls the record's create function. It returnsnullptron a mismatch.INetworkMessageInternalorNetMessageInfo_t.