Repository navigation
Harden JSON handling and add client safety controls - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound successful JSON reads and give applications explicit control over HTTP logging and storage destinations. Keep file streaming, credential isolation and no-retry behavior intact.
HTTPLogFilterfor explicit installation on application output handlers; add optionaldestination_policycallbacks for download redirects and direct uploads.Evidence
After: regression tests cover byte limits regardless of declared length, compression rejection before body consumption, response cleanup, uncertain outcomes, filtered logs, every redirect/upload policy decision and OAuth validation.
Merge Danger
Door: two-way. No migration or persistent state change; revert restores the previous client behavior.
Blast Radius: clients.
Successful JSON exceeding the default limit or using unexpected compression now raises
ProtocolError; callers can configure the size limit. Logging suppression and destination restrictions are opt-in. Private storage remains permitted by default. Mutation/token rejection may leave the outcome uncertain and does not trigger a retry.