Repository navigation
feat(web): optional Vim keybindings in the editor - #32
Open
silviu-life wants to merge 1 commit into
Open
silviu-life wants to merge 1 commit into
silviu-life wants to merge 1 commit into
Conversation
Add a Vim toggle to the editor toolbar, backed by monaco-vim. The choice is stored with the other editor preferences, and a mode line under the editor shows the current mode and pending commands. monaco-vim imports monaco-editor/esm/vs/... paths, which monaco-editor 0.57's exports map rejects, so vite.config.ts aliases them to the exported paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds optional Vim keybindings to the code editor, for people who practise in Vim and keep reaching for
dd/ciwin the browser.pref("vim")).--NORMAL--,--INSERT--,:commands).monaco-vim0.4.4 (MIT, pinned exactly), so it's bundled and works offline like the rest of Monaco.vite.config.tsgets a one-line alias:monaco-vimimportsmonaco-editor/esm/vs/..., which monaco-editor 0.57'sexportsmap rejects, so the Docker web build failed without it. The alias maps those imports to the paths monaco-editor exports.Ctrl+Vblock select,Ctrl+Rredo).How it was tested
npm run lint,format:check,typecheck,npm testandnpm run buildpass. The full app image builds withdocker compose up -d --build.aria-pressed;ogives--INSERT--and inserts text,Escgives--NORMAL--; the setting survives a reload.lib/logic and has no component test setup, and this change is UI wiring. The production build step inmake test-webdoes catch the alias regression. Happy to add a component test if you'd like one, though that means adding jsdom and Testing Library.Checklist
make lintandmake testpass (web parts run; backend/runner untouched)🤖 Generated with Claude Code