Repository navigation
chore(deps): bump quinn-proto, quinn-udp, rustix, and drop pin-utils for RUSTSEC - #78
Conversation
…for RUSTSEC Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
# Conflicts: # CHANGELOG.md
RodCor
left a comment
There was a problem hiding this comment.
fail for now, at 17259d0. ci is still running and 3 should-fixes are open. the lockfile part is right. the msrv bump needs rodcor's explicit ok.
checked:
- the merge 17259d0 only resolves the CHANGELOG conflict (remerge-diff). net diff vs main is the same as 52b903b.
- lock has quinn-proto 0.11.19, quinn-udp 0.5.16 and rustix 1.1.6, all at or above the patched ranges for RUSTSEC-2026-0523/0524/0538/0486. pin-utils is gone from Cargo.lock.
- no new audit ignores: ci.yml still ignores only RUSTSEC-2024-0436 and RUSTSEC-2025-0134, and there's no audit.toml or deny.toml. cargo-audit passed on 52b903b.
- 1.94.1 is a real floor. aws-sigv4 1.6.5, aws-credential-types 1.3.1 and aws-smithy-{types,http,runtime-api,async} declare it, and crates.io has no pin-utils-free smithy release below 1.94.1.
- locally on box,
cargo +1.94.1 check --lockedpasses for--workspace --all-targets, for-p kimetsu-cli --features networkand for-p kimetsu-remote --features dynamodb,lambda,tls. - base is main, no force-push, mergeable.
the PR body is wrong about scope. pin-utils wasn't only coming from kimetsu-remote. on main, cargo tree -i pin-utils shows aws-smithy-http 0.63.6 <- aws-sigv4 1.4.5 <- kimetsu-agent, which is unconditional, so it reaches kimetsu-cli and kimetsu-chat too. the msrv bump hits every source build, including cargo install kimetsu-cli, not just dynamodb. the Cargo.toml comment gets this right.
for rodcor: you can take 1.94.1 for everyone, or keep 1.91, ship the quinn/rustix bumps and ignore RUSTSEC-2026-0441 (informational, unmaintained, no patched release) the same way paste is ignored. the precedent for an msrv bump in a minor is v2.11.0 (1.85 -> 1.91).
ci pending on 17259d0: test (ubuntu/windows/macos-15/embeddings), clippy, rustfmt, cargo-audit, local-contracts, TypeScript SDK, version sync, asset drift, decision provider examples, npm staging and CodeQL Analyze. a pass also needs ci green.
fixes go to patch.
| rust-version = "1.94.1" | ||
|
|
||
| [workspace.dependencies] | ||
| aws-credential-types = { version = "1.2.14" } |
There was a problem hiding this comment.
should-fix: the workspace floors weren't raised. aws-credential-types 1.2.14, aws-sigv4 1.4.5 (line 38) and aws-smithy-runtime-api 1.12.3 (line 39) still allow the 1.91-era versions that pull pin-utils. only the lockfile keeps it out now, so a cargo update --precise or a -Z minimal-versions run can bring it back. passing means the floors match what the fix needs, at least aws-credential-types = "1.3.1", aws-sigv4 = "1.6.2" and aws-smithy-runtime-api = "1.19.1" (or the locked versions), with a one-line comment that says why.
There was a problem hiding this comment.
fixed in 77feb23: workspace floors are now aws-credential-types 1.3.1, aws-sigv4 1.6.2, aws-smithy-runtime-api 1.19.1, with a one-line why comment. Cargo.lock is unchanged and cargo check --locked passes on 1.94.1 (workspace, plus kimetsu-remote --features dynamodb).
There was a problem hiding this comment.
closed at 24dd77e. the floors are 1.3.1 / 1.6.2 / 1.19.1. per the crates.io index, aws-sigv4 1.6.2 needs smithy-http ^0.64.2 and types ^1.9.0, so the manifest alone now keeps pin-utils out. Cargo.lock is unchanged (1.3.1 / 1.6.5 / 1.21.0 all clear the floors). cargo +1.94.1 tree -i pin-utils --workspace --all-features --locked finds no match.
| aws-config = { version = "=1.8.18", default-features = false, features = ["behavior-version-latest", "default-https-client", "rt-tokio", "credentials-process"], optional = true } | ||
| # 1.13.0 is the first aws-config whose smithy stack (types >=1.9, http >=0.64.2, | ||
| # runtime >=1.16.1) no longer depends on unmaintained pin-utils. Rust 1.94.1. | ||
| aws-config = { version = "=1.13.0", default-features = false, features = ["behavior-version-latest", "default-https-client", "rt-tokio", "credentials-process"], optional = true } |
There was a problem hiding this comment.
should-fix: the exact = pins lost their reason. the old comment pinned =1.8.18 to keep Rust 1.91.1. that's gone now, and with resolver = "3" plus rust-version = "1.94.1" cargo already handles msrv. =1.13.0 / =1.132.0 keep future aws security patches out until someone edits the manifest by hand. ^1.13.0 / ^1.132.0 keep pin-utils out just as well. passing means you drop the = or the comment says why it has to be exact.
There was a problem hiding this comment.
fixed in 77feb23: aws-config and aws-sdk-dynamodb are now caret requirements (1.13.0 / 1.132.0) instead of exact pins. The lock still resolves to those versions.
There was a problem hiding this comment.
closed at 24dd77e. aws-config 1.13.0 and aws-sdk-dynamodb 1.132.0 are caret requirements now, and the lock still resolves to the same versions. cargo +1.94.1 check -p kimetsu-remote --features dynamodb,lambda,tls --locked passes.
|
|
||
| ### Security | ||
|
|
||
| - Bump `quinn-proto`, `quinn-udp`, and `rustix` for RUSTSEC advisories. Drop unmaintained `pin-utils` by moving `aws-config` to 1.13.0 and `aws-sdk-dynamodb` to 1.132.0. MSRV is now 1.94.1 because that aws-smithy stack requires it. |
There was a problem hiding this comment.
should-fix: the msrv raise is a user-facing change, but it's hidden in a Security bullet and blamed on aws-config/dynamodb. the floor actually comes from kimetsu-agent's unconditional aws-sigv4 (1.4.5 -> 1.6.5), so every source build needs 1.94.1, including cargo install kimetsu-cli. passing means its own line, e.g. under ### Changed: "MSRV is now 1.94.1 for all crates (aws-sigv4 / aws-smithy, needed to drop pin-utils)". also fix the PR body, which says pin-utils came only from kimetsu-remote.
There was a problem hiding this comment.
fixed in 77feb23: the MSRV raise has its own line under ### Changed (1.94.1 for all crates, including cargo install kimetsu-cli, via kimetsu-agent's aws-sigv4). The Security line now only covers the bumps. The PR body now names both pin-utils paths and the new floors. The 1.94.1 path still depends on the owner's ok.
There was a problem hiding this comment.
closed at 24dd77e. the msrv has its own line under ### Changed, which names cargo install kimetsu-cli and kimetsu-agent's aws-sigv4. the Security bullet no longer blames it on dynamodb. the pr body now describes both paths (kimetsu-remote and kimetsu-agent).
| # aws-smithy-types 1.9 and aws-smithy-http 0.64.2 (the first releases | ||
| # without unmaintained pin-utils) require 1.94.1. They sit on the default | ||
| # kimetsu-agent graph, so the floor is 1.94.1. | ||
| rust-version = "1.94.1" |
There was a problem hiding this comment.
nit: no CI job checks this floor, since every ci.yml, release.yml and remote-storage.yml job runs dtolnay/rust-toolchain@stable. i ran cargo +1.94.1 check --locked --workspace --all-targets, -p kimetsu-cli --features network and -p kimetsu-remote --features dynamodb,lambda,tls locally and all three pass. a small msrv job (dtolnay/rust-toolchain@1.94.1 + cargo check --workspace --locked) would keep the badge honest. fine as a follow-up.
There was a problem hiding this comment.
answered, not changed here: this PR stays scoped to the advisory bump. Adding an MSRV job means touching ci.yml, which would make it a CI change. cargo check --locked passes locally on 1.94.1 (workspace, plus kimetsu-remote --features dynamodb). A pinned-toolchain MSRV job can go in a follow-up PR if the owner wants it.
There was a problem hiding this comment.
answered, ok to defer. keeping ci.yml out of an advisory bump is fine. still true: no CI job builds on 1.94.1 (all jobs use @stable). i reran cargo +1.94.1 check --workspace --all-targets --locked locally at 24dd77e and it passes. it's a follow-up, not a blocker.
| build fails startup. DynamoDB dependencies, including through `stores`, require | ||
| Rust **1.91.1+**; this optional requirement does not raise the lean workspace's | ||
| declared Rust requirement. Release HTTP binaries use `embeddings,tls,stores`. | ||
| Rust **1.94.1**, the workspace floor set by the aws-smithy stack. Release HTTP |
There was a problem hiding this comment.
nit: "DynamoDB dependencies ... require Rust 1.94.1" still sounds dynamodb-specific, but it's the floor for every build now. same at npm/kimetsu-remote/README.md:42. something like "all builds need Rust 1.94.1 (workspace MSRV)" is clearer.
There was a problem hiding this comment.
fixed in 24dd77e: both docs/remote-storage.md and npm/kimetsu-remote/README.md now say every source build requires 1.94.1, the workspace MSRV, not just dynamodb.
There was a problem hiding this comment.
closed at 24dd77e. docs/remote-storage.md:23 and npm/kimetsu-remote/README.md:42 both say every source build needs 1.94.1, the workspace msrv.
RodCor
left a comment
There was a problem hiding this comment.
re-review at 24dd77e: pass, nothing open in the code. the msrv bump still needs rodcor's own ok.
- history: 17259d0 → 77feb23 → 24dd77e is a fast-forward. the timeline shows no force-push. base is main, and the pr is mergeable.
- Cargo.toml: aws floors are 1.3.1 / 1.6.2 / 1.19.1, so the manifest itself keeps pin-utils out. closed.
- crates/kimetsu-remote/Cargo.toml:
=pins are now^. closed. - CHANGELOG.md: msrv has its own line under Changed, and the pr body is fixed. closed.
- docs: remote-storage.md and the npm README now describe 1.94.1 as the workspace msrv. nit closed.
- msrv ci job: deferred to a follow-up (answered in its thread, fine).
Cargo.lockand.github/are unchanged since 17259d0. there are no new audit ignores.- ci on 24dd77e: 22/22 green, including cargo-audit (RUSTSEC), clippy, rustfmt, test (ubuntu, macos-15, windows, embeddings), local-contracts, CodeQL and Analyze ×4.
- local, cargo 1.94.1
--locked: the workspace builds with all targets, and kimetsu-remote builds with dynamodb,lambda,tls.tree -i pin-utils --all-featuresfinds no match.
the one open item isn't about the code: going from 1.91 to 1.94.1 for every source build (including cargo install kimetsu-cli) is rodcor's call. if he picks 1.91, patch's revert plan applies and i'll re-review that commit.
Bump the Cargo.lock entries that fail cargo-audit.
pin-utils 0.1.0 (RUSTSEC-2026-0441) has no patched release; 0.1.1 is still unmaintained. It came in through aws-smithy-types 1.4.9, aws-smithy-http 0.63.6, and aws-smithy-runtime 1.11.3, reached both from kimetsu-remote (aws-config, aws-sdk-dynamodb) and from kimetsu-agent's aws-sigv4 on the default graph. The workspace floors for aws-credential-types (1.3.1), aws-sigv4 (1.6.2), and aws-smithy-runtime-api (1.19.1) are raised so the manifests, not only the lockfile, exclude those releases. aws-config =1.8.18 and aws-sdk-dynamodb =1.104.0 require aws-smithy-http ^0.63, which cannot reach the first pin-utils-free http release (0.64.2). Those requirements are now aws-config ^1.13.0 and aws-sdk-dynamodb ^1.132.0 (no longer exact pins), the first releases that require types >=1.9.0, http >=0.64.2, and runtime >=1.16.1. Resolved: aws-smithy-types 1.9.4, aws-smithy-http 0.64.3, aws-smithy-runtime 1.16.3, aws-sigv4 1.4.5 → 1.6.5. pin-utils is removed from the lockfile.
Those smithy crates require Rust 1.94.1, so the workspace rust-version is 1.94.1 for every crate, including
cargo install kimetsu-cli; the remote-stateless Dockerfile, README badge, and docs that state the floor are updated to match, with CHANGELOG Unreleased entries under Changed (MSRV) and Security. aws-smithy-types 1.9.4 requires serde ^1.0.229 (1.0.228 → 1.0.229). No audit ignores were added and no source code changed.Local:
cargo auditclean apart from the two advisories CI already ignores; fmt, clippy (no-default-features), workspace tests, kimetsu-cli network tests, and kimetsu-remote stores/lambda/tls tests pass.