Repository navigation
network diagram: use type scale tokens for 13px and 15px - #21
Merged
Merged
Conversation
Map kickers from 15px to --km-text-sm and meta and chip labels from 13px to --km-text-xs. Keep the step buttons at 14px. Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
Owner
Author
|
approved at 8f7018a.
|
RodCor
marked this pull request as ready for review
November 13, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagram kickers, meta lines, and chips now use the existing homepage type tokens. Step buttons stay at 14px. Copy is unchanged, including
1.77x,22% to 65%, andabout 99%. Play, Previous, Next, and the step buttons are unchanged in the markup.Mapping
Judged: 15px is 1px from both
--km-text-sm(14px) and--km-text-md(16px).--km-text-smkeeps the kicker one step above the meta and chips. 13px is 1px from both--km-text-xs(12px) and--km-text-sm(14px).--km-text-xskeeps those labels on the caption step. Computed sizes below are measured in Chrome with a 16px root.0.9375rem)--km-text-sm(0.875rem)0.8125rem)--km-text-xs(0.75rem)0.875rem)The reduced-motion note stays
0.75rem. Measured computed size: 12px, and it staysdisplay: noneunless reduced motion is on.Judged:
tests/homepage-type-scale.test.mjslists homepage TSX files and rejects Tailwind size utilities. The diagram CSS module does not fit that check, because the step buttons and the note stay literal sizes on purpose. The token assertion is intests/network-diagram.test.mjs.Font sizes
Measured. Chrome, static homepage, viewports 1440×900 and 390×844. A size is a distinct computed
font-sizeon a visible element (notdisplay: noneorvisibility: hidden) inside.km-homethat has direct text or is a form control.document.bodyhad the same sets.8c00bd5)Section height
Measured.
#networkgetBoundingClientRect().heightafter pausing on step 5. PNG heights match these numbers. The diagram card was 382px at 1440 and 766px at 390 on both builds.Controls
Measured after, tabbing from “Read the Network guide”: Play, Previous, Next, then steps 1–5. Judged unchanged, because the markup was not edited.
axe-core 4.14.0
Measured. Tags
wcag2a,wcag2aa,wcag21a,wcag21aa,wcag22aa. Homepage paused on step 5.color-contrast, 14 nodes)color-contrast, 14 nodes)The same pause on main produced the same 14
color-contrastnodes. Measured. An unpaused main run was also 0 violations (30 passes, 11 incomplete nodes); the extra incomplete nodes are the step 5 labels, on both builds.Lighthouse
Measured. Lighthouse 13.6.0, mobile, simulated throttling, performance category, local static build. Median of 5 runs.
The 89 run had LCP 3763ms. The other nine runs had LCP about 910ms. Median is unchanged.
Check
Measured.
npm run checkpassed: Biome, types, 45 tests, static build.Screenshots
On
pr-assetsat3e5f5d4.1440 before
1440 after
390 before
390 after
Loop, steps 1, 3, and 5
Reduced motion