Repository navigation
home: delete unmounted projects-section and home-visuals - #20
Merged
Merged
Conversation
Neither file is imported by a page or a test. The km-* classes they used are still used by mounted sections, so global.css stays as it is. Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
Owner
Author
|
changes needed at 30969cf. one blocker:
|
Keep home-visuals.tsx deleted. main modified that unmounted file in the type-scale change. Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
The type-scale test reads every path in homeFiles. That file is unmounted and deleted, so the list no longer includes it. Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
Owner
Author
|
approved at c65a2ed.
|
RodCor
marked this pull request as ready for review
November 13, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
src/app/(home)/_components/projects-section.tsx: dead code, not mounted on any page.src/app/(home)/_components/home-visuals.tsx: dead code, not mounted on any page. The modify/delete conflict with main kept the deletion.tests/homepage-type-scale.test.mjs: dropsrc/app/(home)/_components/home-visuals.tsxfromhomeFiles, because that test reads every listed file and this one is deleted.src/app/global.css: no rules removed.km-section,km-eyebrow,km-heading,km-text-link, and the type-scale tokens are still used by mounted sections.Base
Merged
origin/mainat8c00bd57fa189fcd92b840763a0c1e7f8af9805d(type scale, #17) with a merge commit. No rebase.Import check
After the merge, ripgrep across the repo, including
tests/, excludingnode_modules,.next,out, and.git:No matches.
Lines removed
Against
8c00bd5: 154 lines. 98 inprojects-section.tsx, 55 inhome-visuals.tsx, and 1 intests/homepage-type-scale.test.mjs.npm run checkonc65a2ed74ca6e3e75247464556597e992c3a1585Passed. Biome checked 58 files and applied no fixes.
tsc --noEmitpassed. Tests: 44 passed, 0 failed, including both homepage type-scale tests.next buildsucceeded and the postbuild static-output check verified 11 required routes.Homepage screenshots
Built static homepage on main
8c00bd5and on this head. Full-page captures at CSS viewports 1440 and 390, dark theme (the site default),prefers-reduced-motion: reduceso the network diagram is on its settled step. Pixelmatch threshold 0:cfc89908034204cf1a06b15ef2bccae51520fd217ea15f05e96b93e5b2a5a9dd.9cf5162b8de5349a990ca99239c82f75f6e8293825a33bca9241e7817c4f453a.The before and after PNGs are byte-identical at each width.
Screenshots are pinned to assets commit
8cc4ee5861a4eeeb698d841126cc959bcbb4bdf9oncursor/pr-assets-item6.1440
Before (
8c00bd5)After
390
Before (
8c00bd5)After