Skip to content

home: delete unmounted projects-section and home-visuals - #20

Merged
RodCor merged 3 commits into
mainfrom
cursor/delete-unmounted-home-components-e953
Nov 13, 2026
Merged

RodCor merged 3 commits into
mainfrom
cursor/delete-unmounted-home-components-e953

Conversation

@RodCor

@RodCor RodCor commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • src/app/(home)/_components/projects-section.tsx: dead code, not mounted on any page.
  • src/app/(home)/_components/home-visuals.tsx: dead code, not mounted on any page. The modify/delete conflict with main kept the deletion.
  • tests/homepage-type-scale.test.mjs: drop src/app/(home)/_components/home-visuals.tsx from homeFiles, because that test reads every listed file and this one is deleted.
  • src/app/global.css: no rules removed. km-section, km-eyebrow, km-heading, km-text-link, and the type-scale tokens are still used by mounted sections.

Base

Merged origin/main at 8c00bd57fa189fcd92b840763a0c1e7f8af9805d (type scale, #17) with a merge commit. No rebase.

Import check

After the merge, ripgrep across the repo, including tests/, excluding node_modules, .next, out, and .git:

rg -n --hidden -g '!node_modules' -g '!.next' -g '!out' -g '!.git' 'home-visuals|projects-section' .

No matches.

Lines removed

Against 8c00bd5: 154 lines. 98 in projects-section.tsx, 55 in home-visuals.tsx, and 1 in tests/homepage-type-scale.test.mjs.

npm run check on c65a2ed74ca6e3e75247464556597e992c3a1585

Passed. Biome checked 58 files and applied no fixes. tsc --noEmit passed. Tests: 44 passed, 0 failed, including both homepage type-scale tests. next build succeeded and the postbuild static-output check verified 11 required routes.

Homepage screenshots

Built static homepage on main 8c00bd5 and on this head. Full-page captures at CSS viewports 1440 and 390, dark theme (the site default), prefers-reduced-motion: reduce so the network diagram is on its settled step. Pixelmatch threshold 0:

  • 1440: 1440×3234, 0 differing pixels of 4,656,960. SHA-256 cfc89908034204cf1a06b15ef2bccae51520fd217ea15f05e96b93e5b2a5a9dd.
  • 390: 390×5650, 0 differing pixels of 2,203,500. SHA-256 9cf5162b8de5349a990ca99239c82f75f6e8293825a33bca9241e7817c4f453a.

The before and after PNGs are byte-identical at each width.

Screenshots are pinned to assets commit 8cc4ee5861a4eeeb698d841126cc959bcbb4bdf9 on cursor/pr-assets-item6.

1440

Before (8c00bd5)

Homepage before, 1440px

After

Homepage after, 1440px

390

Before (8c00bd5)

Homepage before, 390px

After

Homepage after, 390px

Open in Web Open in Cursor 

Neither file is imported by a page or a test. The km-* classes they used are still used by mounted sections, so global.css stays as it is.

Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
@RodCor

RodCor commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

changes needed at 30969cf. one blocker:

  • Use a seven-step type scale on the homepage #17 merged as 8c00bd5, and this PR now conflicts with main. Use a seven-step type scale on the homepage #17 edited home-visuals.tsx, and tests/homepage-type-scale.test.mjs lists that file in homeFiles, so deleting it breaks verify.
  • to pass: merge main in (no rebase), keep the deletion, drop "src/app/(home)/_components/home-visuals.tsx" from homeFiles in the test, and show npm run check green on the new head. re-check rg on the merged tree as well.
    everything else looks right: subtract-only, nothing imported these files, and 0 px diff at 1440 and 390.

cursoragent and others added 2 commits November 13, 2026 19:19
Keep home-visuals.tsx deleted. main modified that unmounted file in the type-scale change.

Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
The type-scale test reads every path in homeFiles. That file is unmounted and deleted, so the list no longer includes it.

Co-authored-by: Rodrigo <rodrigo.ccordoba@hotmail.com>
@RodCor

RodCor commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

approved at c65a2ed.

  • the blocker is fixed: main (8c00bd5) is merged in with no rebase, home-visuals.tsx stays deleted, and the test's homeFiles no longer lists it.
  • rg on the merged tree finds no matches for projects-section, home-visuals, ProjectsSection, HomeVisuals or BrainSharing. npm run check passes locally on c65a2ed (lint, types, tests, build, static-output check).
  • the diff is subtract-only (154 deletions in 3 files) with 0 px diff at 1440 and 390, so no design-bar items apply.
  • non-blocking: the PR body still says "no other files changed" and the before screenshots are from main at 550340b. please update it to mention the test edit.
    ci verify was still running at review time. merge only when it's green.

@RodCor
RodCor marked this pull request as ready for review November 13, 2026 19:23
@RodCor
RodCor merged commit 5215b80 into main Nov 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants