Repository navigation
Fix base client briefs and saved agent startup regressions - #881
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Networkclients: lazily obtain one shared knowledge service while retaining project database routing and historical attribution. Progress saves use the same initializer.cursoras an alias ofcursor-cli.cursor-cli-claude-…helper previously became familycli, affecting model diversity/routing.Authentication requiredanduse /loginmessages in the existing signed-out path before reconnection/fatal fallback.Evidence and verification
An isolated baseline reproduction raised
AttributeErrorin the base brief, rejected the saved Cursor ID, classified the current Cursor helper ascli, and missed both sign-in messages. New synthetic regressions cover legacy/migrated databases, knowledge isolation, concurrent first use, aliases and multiword helper IDs. Existing Kimi assertions were updated to its current connector's declared family; its behavior is unchanged.303 targeted tests passed with 11 platform/tool skips before integration with #880. After rebasing onto #880, 317 targeted tests passed with 11 platform/tool skips in 54.01s. Ruff over src/tests/projects and diff checks pass. No UI markup changes; no screenshot needed. No live project tests, model requests, runtime updates or matching-rule changes.
Remaining issues
The previous #870 Linux full-suite job reported 92 failures (8578 passed), including stale project-store test doubles and separate behavioral failures. This PR fixes specific reproduced failures; it does not claim the full suite is green. Current check workflow is disabled manually and main has no required checks; no workflow is re-enabled here.
The new hourly evidence contained 850 transcript records, 27 repair examples and 2675 slow-read warnings. Tool timings still show up to 1350.520s verification admission wait, distinct from requesting-call SQL execution and fetch. No safe admission-policy change follows without identifying the semaphore holder/work type and changed file inputs. The existing full-file/exact-judge gates remain intact. Detailed private evidence and continuation checkpoints stay outside Git.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.