Skip to content

Fix base client briefs and saved agent startup regressions - #881

Merged
RetroGameDeveloper merged 1 commit into
mainfrom
fix/hourly-evidence-1708
Nov 8, 2026
Merged

RetroGameDeveloper merged 1 commit into
mainfrom
fix/hourly-evidence-1708

Conversation

@RetroGameDeveloper

@RetroGameDeveloper RetroGameDeveloper commented Nov 8, 2026 •

Copy link
Copy Markdown

Changes

  • Fix full function briefs for base Network clients: lazily obtain one shared knowledge service while retaining project database routing and historical attribution. Progress saves use the same initializer.
  • Accept the earlier saved Cursor kind cursor as an alias of cursor-cli.
  • Parse the longest registered helper kind before choosing a model family. A current cursor-cli-claude-… helper previously became family cli, affecting model diversity/routing.
  • Recognize explicit Authentication required and use /login messages in the existing signed-out path before reconnection/fatal fallback.

Evidence and verification

An isolated baseline reproduction raised AttributeError in the base brief, rejected the saved Cursor ID, classified the current Cursor helper as cli, and missed both sign-in messages. New synthetic regressions cover legacy/migrated databases, knowledge isolation, concurrent first use, aliases and multiword helper IDs. Existing Kimi assertions were updated to its current connector's declared family; its behavior is unchanged.

303 targeted tests passed with 11 platform/tool skips before integration with #880. After rebasing onto #880, 317 targeted tests passed with 11 platform/tool skips in 54.01s. Ruff over src/tests/projects and diff checks pass. No UI markup changes; no screenshot needed. No live project tests, model requests, runtime updates or matching-rule changes.

Remaining issues

The previous #870 Linux full-suite job reported 92 failures (8578 passed), including stale project-store test doubles and separate behavioral failures. This PR fixes specific reproduced failures; it does not claim the full suite is green. Current check workflow is disabled manually and main has no required checks; no workflow is re-enabled here.

The new hourly evidence contained 850 transcript records, 27 repair examples and 2675 slow-read warnings. Tool timings still show up to 1350.520s verification admission wait, distinct from requesting-call SQL execution and fetch. No safe admission-policy change follows without identifying the semaphore holder/work type and changed file inputs. The existing full-file/exact-judge gates remain intact. Detailed private evidence and continuation checkpoints stay outside Git.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@RetroGameDeveloper
RetroGameDeveloper merged commit e8b3ac3 into main Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant