Skip to content

Fix Windows startup migration snapshot flush - #879

Merged
RetroGameDeveloper merged 1 commit into
mainfrom
fix/windows-migration-fsync
Nov 8, 2026
Merged

RetroGameDeveloper merged 1 commit into
mainfrom
fix/windows-migration-fsync

Conversation

@RetroGameDeveloper

@RetroGameDeveloper RetroGameDeveloper commented Nov 8, 2026 •

Copy link
Copy Markdown

The real portable EXE startup smoke check on Blacksmith failed with EBADF in project_migration.durable: Windows FlushFileBuffers requires a writable handle. Open the owned migration snapshot with r+b before fsync, preserving its contents and the existing directory flush on Unix. Added a real file flush regression test. Local validation: 2 passed, 1 Windows-only test skipped; Ruff passed. The release build will verify full startup, health and Stop on Windows before publication.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@RetroGameDeveloper
RetroGameDeveloper merged commit 6b1babc into main Nov 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant