Skip to content

test: keep release benchmark timing enabled - #20

Merged
Reddimus merged 1 commit into
mainfrom
fix/benchmark-timing-20261025
Oct 26, 2026
Merged

Reddimus merged 1 commit into
mainfrom
fix/benchmark-timing-20261025

Conversation

@Reddimus

Copy link
Copy Markdown
Owner

Keep the optimized parse benchmark timing limit enabled when CMake supplies an empty argument. Only the explicit --no-timing flag disables the limit for Debug and sanitizer runs.

Validated optimized runs with empty and explicit bypass arguments, the rebuilt ASan benchmark, formatting, and Markdown lint. This changes test infrastructure only.

@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The benchmark now skips its timing limit only when given exactly --no-timing.

  • The parse benchmark keeps its timing limit on unless you pass --no-timing.

Reviews (1) · Last reviewed commit: "test: keep release benchmark timing enab..." · Reviewed by Greptile

@Reddimus
Reddimus merged commit 7622eac into main Oct 26, 2026
5 checks passed
@Reddimus
Reddimus deleted the fix/benchmark-timing-20261025 branch October 26, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant