Repository navigation
Conversation
hCoureau
marked this pull request as ready for review
November 11, 2026 19:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature-doc generator passes YAML nickname strings into a decoder keyed by
RoborockProductNickname, so family-derived flags differ from runtime decoding. Resolve known names to enum members and report invalid names before writing the output. When family metadata is missing, empty or Unknown, use the runtime model lookup and its PEARLPLUS fallback for unrecognised models.Keep raw capability metadata as values rather than replacing it with
X, then regenerateSUPPORTED_FEATURES.mdfrom the branch catalogue and existing Home API fixtures. Tests compare generated flags with the actualHomeDataProduct.product_nicknamelookup, covering known and unknown models with missing family metadata, as well as invalid names and raw metadata. Runtime decoding and catalogue data remain unchanged. The existing non-V1 columns describe V1 decoder results.Validation: 2,289 tests passed on each of Python 3.11 and 3.14; pre-commit, commitlint and source/wheel builds passed. Repeated generation is byte-identical. The combined checkout passes 2,310 tests on each Python version.
The reconnect test now waits for the ready callback rather than transport connection, which can precede initialization. This fixes the timing race exposed by the Python 3.11 CI run and ensures the manager closes if an assertion fails.
Related to #1016.