Repository navigation
Conversation
hCoureau
marked this pull request as ready for review
November 10, 2026 22:11
infy1995
added a commit
to infy1995/python-roborock
that referenced
this pull request
Nov 11, 2026
Keep the B01 snapshots and exclude only A01 devices, which report their features on a data point. Report the F25 Ultra family as Unknown in device_info.yaml, matching what get-device-info exports for unmapped models after Python-roborock#1029.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roborock get-device-infocurrently exportsPEARLPLUSfor unrecognized product models because it uses the runtime family fallback. Look up the model mapping directly so these exports reportUnknown, while mapped models retain their existing family names. Correct the same stale labels in the device catalogue forsc05,a288, andss07.Validation: 81 CLI and supported-feature tests, offline verification that only those three catalogue values changed, the full default suite on Python 3.14 (2,283 passed; 53 xfailed), all pre-commit checks and commitlint. Source/wheel builds passed for the CLI change; the catalogue is excluded from those packages. All 11 real-broker MQTT tests pass on the combined changes on Python 3.11 and 3.14. The production get-device-info command was also run against the Qrevo 2 Pro using an authenticated cache scoped in memory to that device: live capability replies were received and the export reported Unknown. Account cache files and device settings were unchanged.