Repository navigation
test: add end-to-end multi-part map content trait tests - #1008
Merged
Lash-L merged 2 commits intoNov 1, 2026
Merged
Conversation
Add map_parts and map_part_order support to V1VacuumSimulator and exercise MapContentTrait end-to-end across single-part and multi-part map responses.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Payload splitting can divide the eight-byte endpoint across chunks, preventing the decoder from completing the response and causing map RPC timeouts even after all parts arrive.
1 open issue
What changed in this PR
This PR strengthens V1 map integration coverage by testing MapContentTrait through the simulator’s real RPC channels rather than mocked map responses.
Changes:
- Adds configurable multipart map responses and delivery order to
V1VacuumSimulator. - Exercises map parsing, unchanged-map handling, robot movement updates, and malformed payloads end-to-end.
- Adds a simulator test checking multipart framing and reassembled content.
| File | Description |
|---|---|
tests/testing/test_v1_simulator.py |
Verifies multipart message protocols, sequence numbers, and reassembly. |
tests/devices/traits/v1/test_map_content.py |
Replaces mock-based tests with simulator-backed map trait coverage. |
roborock/testing/v1_simulator.py |
Adds configurable encrypted map splitting and delivery order. |
Review effort: Balanced
Split only the encrypted map body across map_parts and prepend the 24-byte header to the first part so high part counts cannot split the endpoint header.
Lash-L
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map_partsandmap_part_ordersupport toV1VacuumSimulatorto split encrypted V1 map responses acrossMAP_RESPONSE_PART(300) andMAP_RESPONSE(301) messages in configurable delivery orders.tests/devices/traits/v1/test_map_content.pywith end-to-endMapContentTraittests backed byV1VacuumSimulator, covering single-part and multi-part responses (in-order and out-of-order), unchanged-map skip logic, robot path/pose updates, and malformed payload handling.