Repository navigation
Conversation
Newer firmware (seen on a QRevo, fw 02.28.26) rejects the individual set_custom_mode / set_mop_mode / set_water_box_custom_mode commands with -10005 "param error" while the robot is in SmartPlan mode. The routine runner sent set_custom_mode first, so every routine aborted before the cleaning command and the robot never moved. When a scene step carries fan_power, mop_mode and water_box_mode, send them together with set_clean_motor_mode, which is what the Roborock app does and which the firmware accepts in every mode. Steps that only carry some of these settings keep the previous per-setting commands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On newer firmware (seen on a QRevo Master, fw
02.28.26), routines started from the app or Home Assistant never move the robot while it is in SmartPlan mode.The routine runner sends the scene settings one by one (
set_custom_mode,set_water_box_custom_mode,set_mop_mode). In SmartPlan mode the firmware rejects each of them with-10005 "param error", so the routine aborts beforeapp_segment_clean/app_start:The Roborock app changes these settings with a single
set_clean_motor_modecall, which the firmware accepts in every mode (including switching into and out of SmartPlan:{"fan_power":110,"mop_mode":306,"water_box_mode":209}).Fix
When a scene step carries
fan_power,mop_modeandwater_box_mode,_settings_commandsnow sends them together:Steps that only carry some of these settings keep the previous per-setting commands, so older models are unaffected.
Testing
set_custom_mode).uv run --extra dev pytest -q tests/→ 461 passed.set_clean_motor_mode error=None,app_segment_clean error=None, robot enters segment cleaning). Tested it myselfThanks