[NicolasBonduel]

Problem

On the official Android app (4.76.08, S7 MaxV a27, device plugin 5208), the device page can stay on "Loading map" forever. MQTT is connected, status and room requests succeed, but the plugin never sends get_map_v1.

When the device page opens, the plugin requests GET /api/v1/product/agreementAndPolicy?country=..&productid=... The server has no route for it, so the catch-all answers {"ok": true, "route": "..."}. The plugin reads userAgreement.langUrl and privacyProtocol.langUrl from that and passes them to the native PluginSDKModule.openPrivacyLicense. That method throws a NullPointerException on the null arguments, and its callback never fires.

You can't see this in logcat. MessageQueueThreadHandler.dispatchMessage catches every NullPointerException and logs a generic React Native warning without the original exception. I found it with a diagnostic build that logs the swallowed throwable:

E RRMapDiagnostic: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
E RRMapDiagnostic:   at com.roborock.smart.react.PluginSDKModule.openPrivacyLicense(...)
E RRMapDiagnostic:   at com.facebook.react.bridge.JavaMethodWrapper.invoke(...)

The plugin only takes this path when the app has no saved agreement acceptance for the device. In my case it started after a fresh login and clearing the app's storage, while the same app and server had shown maps before.

This is a sibling of #209 (checkAppAgreement). Both requests are part of the same agreement gate before the map loads.

Fix

Add a dedicated product_agreement_and_policy_v1 route that returns the app's AgreementAndPrivacyInfo shape. It reuses the userAgreement and privacyProtocol documents (version + langUrl) that /api/v4/app/agreement/latest already serves. _AGREEMENT_LATEST_DATA in routes/api/v4/agreement.py becomes public as AGREEMENT_LATEST_DATA so both routes share one copy.

Tests

tests/test_product_agreement_and_policy.py

• the path resolves to the new route and returns both documents with a version and an https:// English URL
• the documents match /api/v4/app/agreement/latest

Both tests fail on main and pass with the fix. Full suite: 460 passed.

Live check (Nov 2026): applied to a running stack with the patched Android app 4.76.08 and an S7 MaxV. After the change, the map rendered on a cold start and after reopening the device page, and the app sent get_map_v1. Before it, the page stayed on "Loading map".

🤖 Generated with Claude Code

[Copilot]

🟢 Approval recommended

No active review issues are reported for the new agreement-document endpoint.

No open issues 🎉

What changed in this PR

Adds a dedicated agreement-document endpoint to prevent the Android device plugin from stalling on “Loading map” when agreement acceptance is not saved. This complements the existing checkAppAgreement route.

Changes:

• Registers /api/v1/product/agreementAndPolicy and returns user agreement and privacy documents.
• Shares document data with /api/v4/app/agreement/latest.
• Adds tests for route resolution, response structure, HTTPS URLs, and consistency with the v4 endpoint.

File	Description
tests/​test_product_agreement_and_policy.py	Tests routing, document fields, and consistency with v4 agreements.
src/​roborock_local_server/​bundled_backend/​https_server/​routes/​api/​v4/​agreement.py	Exposes agreement data for reuse by both routes.
src/​roborock_local_server/​bundled_backend/​https_server/​routes/​api/​v1/​agreement.py	Adds the product agreement matcher and response builder.
src/​roborock_local_server/​bundled_backend/​https_server/​endpoint_rules.py	Registers the new endpoint.

_{Review effort: Balanced}