Repository navigation
MP3: ask the board for its buffered latency - #37
Merged
Merged
Conversation
A player doesn't need an instrument's latency, and on a board that sizes its ring from it (the GIGA's DAC) more buffering rides out stalls of the interpreter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An MP3 player doesn't need an instrument's latency. The MP3 app now opens its output with
latency="buffered". A board that sizes its ring from that, like the GIGA R1's DAC (PyDevices/pydevices#433), buffers about 250 ms instead of 93 ms. Boards whose buffered profile is their own default are unchanged. Anaudio_outthat takes nolatencyis opened as before.