Repository navigation
stack.py: read the data file beside the script - #103
Merged
Merged
Conversation
A checkout outside the sibling layout, such as a git worktree, read another checkout's data/stack.json, or none, and rendered the page from that. The script now reads the data it was committed with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A checkout outside the sibling layout, such as a git worktree, read another checkout's
data/stack.jsonor none at all, because the path was built from the folder above the checkout. Rendering a page from a worktree could then drop a row added on that branch. The path now comes from the script's own folder, so a checkout always reads its own data.In a worktree the old path resolved to a folder that doesn't exist and the new one resolves to the worktree's own file. In the usual sibling layout, which CI uses, both give the same file. I ran
stack.py --checkfrom the worktree against the sibling checkouts; the workflow's check runs on this PR. I didn't change--root, which still defaults to the folder above the checkout.