Repository navigation
fix(hygiene_ci): count simulate_if_needed as the simulates lever - #549
Merged
Merged
Conversation
levers_from_text flags a script as `simulates` when its text contains `should_simulate(`. The workspaces are being swept onto the one-line wrapper `util.dataset.simulate_if_needed(...)`, which does not contain that token, so swept scripts would silently lose the lever. Match both, with a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016nhQ8NyQo2s3YUk8eUrrB3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PyAutoLabs/autogalaxy_workspace#268 (phase 3 of PyAutoLabs/PyAutoArray#669).
Summary
levers_from_textinagents/conductors/hygiene/_hygiene_ci.pyflags a script with thesimulateslever when its text containsshould_simulate(. The workspaces are being swept onto the one-line wrapperutil.dataset.simulate_if_needed(...), which doesn't contain that token, so roughly 490 swept scripts would silently lose the lever. This change matches both names and updates the lever's docstring.It's a source-text match only, so it can merge independently of the library release.
Testing
test_simulate_if_needed_counts_as_simulates.tests/test_hygiene_ci.py: 11 passed (10 before this change).repos_sync.py --check --only "tenant firewall (organ code)") passes locally; no repo name appears in the organ code.Merge mode: human
/prm.Generated by Claude Code