Repository navigation
Verify Quarantine - #827
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Quarantine (1994) (Imagexcel) (added #524)
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
There are several config files, but they come straight from the disk, or DoDAT is somehow able to generate them already, so I left them in the DOSZ. The exception is
SOUND.DAT, which I removed because it's in the DOSC with Sound Blaster 16 selected instead of PC Speaker.Have any official patches been applied, if necessary?
No official patches mentioned by PCGamingWiki.
Is the game data in the root of the ZIP (unless game does not work that way)?
The files are in
C:\Qbecause the sound doesn't seem to work when they're inC:\.Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
It isn't on GOG/Steam.
Can the game benefit from using embedded data or embedded patches in the datfile?
I added it to the BAT files used to run the game, allowing DoDAT to build from the disc image.
Can DoDAT build the game from the install media?
Yes, with the embedded data.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
No.
Do the file timestamps match the installation media?
No, I added them for the files on the disc.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
No, I tried extracting all files and editing the path in
CD.DAT, but it didn't work.For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
It already uses the smallest option (though the comment erroneously said it was a complete install).
Can the game benefit from using CHDtoOGG?
Yes, it's already used.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
Yes. I changed it from BPS to slightly smaller IPS.
Is the game running at the correct speed? Is CPU year specified?
cpu_year: 1992was already set to reduce the game speed. I changed tocpu_max_yearsince it's technically dynamic, but same effect anyway.Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
No, I added run_input and WAITMODECHANGE.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
No.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Not applicable.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
I added run_utility to the Intro launch config because it's unlikely people would want to sit through it every time (it didn't seem skippable).
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Comment
Summary of changes:
SOUND.DATfrom DOSZcpu_max_yearUnmentioned in the checklist:
sound_gus: false, but this is already supposed to be the default, so I removed it. Also removed a redundantcpu_year: 1992there.