Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 34 additions & 22 deletions ProcessMaker/Models/ProcessRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1076,29 +1076,15 @@ public function evaluateCaseTitle(string $mustacheTitle, array $data, bool $form
]);
$title = $mustache->render($mustacheTitle, $data);
// multi-byte 200 characters limit
$titleParts = preg_split('/(<b>|<\/b>)/', $title, -1, PREG_SPLIT_DELIM_CAPTURE);
$title = '';
$size = 200;
$len = 0;
foreach ($titleParts as $i => $part) {
if ($part === '<b>' || $part === '</b>') {
$title .= $part;
continue;
}
if ($len + mb_strlen($part) >= $size) {
$part = mb_substr($part, 0, $size - $len);
$title .= $part;
$nextPart = $titleParts[$i + 1] ?? '';
if ($nextPart === '</b>') {
$title .= $nextPart;
}
break;
}
$title .= $part;
$len += mb_strlen($part);
}
$title = $this->truncateFormattedCaseTitle($title);
} else {
$mustache = new MustacheExpressionEvaluator();
$mustache = new MustacheExpressionEvaluator([
'escape' => function ($value) {
return is_scalar($value) || $value === null
? (string) $value
: '';
},
]);
$title = $mustache->render($mustacheTitle, $data);
// multi-byte 200 characters limit
$title = mb_substr($title, 0, 200);
Expand All @@ -1107,6 +1093,32 @@ public function evaluateCaseTitle(string $mustacheTitle, array $data, bool $form
return $title;
}

private function truncateFormattedCaseTitle(string $renderedTitle, int $size = 200): string
{
$titleParts = preg_split('/(<b>|<\/b>)/', $renderedTitle, -1, PREG_SPLIT_DELIM_CAPTURE);
$title = '';
$len = 0;
foreach ($titleParts as $i => $part) {
if ($part === '<b>' || $part === '</b>') {
$title .= $part;
continue;
}
if ($len + mb_strlen($part) >= $size) {
$part = mb_substr($part, 0, $size - $len);
$title .= $part;
$nextPart = $titleParts[$i + 1] ?? '';
if ($nextPart === '</b>') {
$title .= $nextPart;
}
break;
}
$title .= $part;
$len += mb_strlen($part);
}

return $title;
}

public function isSystem()
{
$systemCategories = ProcessCategory::where('is_system', true)->pluck('id');
Expand Down
24 changes: 24 additions & 0 deletions tests/unit/ProcessMaker/CaseTitleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,18 @@ public function testEvaluateCaseTitleWithoutFormatting()
$this->assertEquals('Hello, World!', $title);
}

public function testEvaluateCaseTitleWithoutFormattingPreservesAmpersand()
{
$processRequest = new ProcessRequest();
$title = $processRequest->evaluateCaseTitle(
'Research {{department}}',
['department' => 'Research & Development'],
false
);

$this->assertSame('Research Research & Development', $title);
}

public function testEvaluateCaseTitleWithFormatting()
{
$processRequest = new ProcessRequest();
Expand All @@ -24,6 +36,18 @@ public function testEvaluateCaseTitleWithFormatting()
$this->assertEquals('Hello, <b>World</b>!', $title);
}

public function testEvaluateCaseTitleWithFormattingEscapesAmpersandForHtml()
{
$processRequest = new ProcessRequest();
$title = $processRequest->evaluateCaseTitle(
'Research {{department}}',
['department' => 'Research & Development'],
true
);

$this->assertSame('Research <b>Research &amp; Development</b>', $title);
}

public function testEvaluateCaseTitleWithCharacterLimit()
{
$processRequest = new ProcessRequest();
Expand Down
Loading