[Copilot]

PR Summary

Follow-up to #2270, targeting its branch rather than main.

The review finding is reproducible: a resource-shaped call to a script-defined function is treated as a DSC declaration because command discovery uses a separate runspace. Commands inside its script block arguments are then incorrectly suppressed. Both new regression cases returned zero diagnostics before the fix instead of the two expected diagnostics.

• Recognize function declarations in enclosing script-block scopes, case-insensitively, without searching unrelated nested scopes.
• Use that information consistently for resource declarations and their same-line/following-line bodies. Do not apply implicit Get- prefix corrections to script-defined function calls; preserve explicit alias handling.
• Cover script-level and configuration-level functions, both brace layouts, unrelated scopes, and formatter behavior. Document the distinction.

Validation: .NET 8 and .NET Framework 4.6.2 builds succeeded. Alias tests: 23 passed, 2 Windows-only tests skipped on Linux. Formatter integration tests: 10 passed. Executed using PowerShell 7.4.13 and Pester 5.7.1; the configured Pester 6.0.1 package was unavailable from the accessible mirror.

PR Checklist

• PR has a meaningful title
• Summarized changes
• Change is not breaking
• All changed source files have the correct copyright header
• Added regression tests and updated documentation
• This PR is ready to merge and is not Work in Progress (opened as a draft)

[Copilot]

🟡 Changes recommended

Scoped function declarations are mishandled, causing incorrect alias rewrites and suppressed diagnostics, while repeated scope scans introduce quadratic analysis overhead.

2 open issues

• Handle scoped function declarations and visibility in analysis · New
• Index function declarations to avoid repeated AST traversal · New

What changed in this PR

This follow-up to #2270 distinguishes script-defined function calls from DSC resource declarations so alias analysis preserves function names while checking commands in their script-block arguments.

Changes:

• Adds case-insensitive function lookup in enclosing script-block scopes and reuses it in DSC classification.
• Adds regression coverage for function scope, brace layouts, unrelated scopes, and formatter behavior.
• Documents the distinction between functions, DSC resources, and implicit aliases.

File	Description
Tests/​Rules/​AvoidUsingAlias.tests.ps1	Adds function-detection and formatter regression tests.
Rules/​AvoidAlias.cs	Uses script-defined function detection in alias and DSC handling.
docs/​Rules/​AvoidUsingCmdletAliases.md	Explains function and DSC resource exclusions from implicit alias correction.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Scope handling still changes command resolution for dot-sourced private functions and incorrectly treats script/global declarations in unexecuted nested functions as visible, causing missed diagnostics and unsafe corrections.

2 open issues

• Handle dot-sourced blocks using caller scope · New
• Keep nested script/global declarations in lexical scope · New

2 resolved since last review

• Index function declarations to avoid repeated AST traversal
• Handle scoped function declarations and visibility in analysis

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Dot-sourced scope handling still misindexes declarations and incorrectly skips script-block argument scopes, causing both erroneous alias corrections and missed diagnostics.

2 open issues

• Avoid skipping scopes for script-block command arguments · New
• Index dot-sourced declarations in the effective caller scope · New

2 resolved since last review

• Keep nested script/global declarations in lexical scope
• Handle dot-sourced blocks using caller scope

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The argument-count restriction incorrectly treats parameterized dot-sourced blocks as child scopes, causing erroneous alias formatting and missed declarations in the caller’s scope.

1 open issue

• Fix scope handling for parameterized dot-sourced blocks · New

2 resolved since last review

• Index dot-sourced declarations in the effective caller scope
• Avoid skipping scopes for script-block command arguments

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved scope and execution-order errors in AvoidAlias suppress expected Get-Verb diagnostics and cause valid function calls to be incorrectly rewritten.

6 open issues

• Check declaration visibility for immediately invoked child blocks · New
• Compare named-block execution phases before source offsets · New
• Resolve callback scopes without declarations from the callback itself · New
• Resolve positional member arguments before selecting callback parameters · New
• Traverse parenthesized literal script blocks · New
• Recognize module-qualified ThreadJob commands for isolation checks · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved scope-resolution bugs in AvoidAlias incorrectly rewrite valid Verb calls as Get-Verb in callbacks and nested or parenthesized dot-sourced blocks.

3 open issues

• Track named blocks until reaching the containing function · New
• Unwrap parenthesized dot-source operands before scope checks · New
• Resolve callback scope using argument types and parameter sets · New

6 resolved since last review

• Recognize module-qualified ThreadJob commands for isolation checks
• Traverse parenthesized literal script blocks
• Resolve positional member arguments before selecting callback parameters
• Resolve callback scopes without declarations from the callback itself
• Compare named-block execution phases before source offsets
• Check declaration visibility for immediately invoked child blocks

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because complex scope and execution-order interactions can cause incorrect alias rewrites and suppress valid diagnostics.

No open issues 🎉

3 resolved since last review

• Resolve callback scope using argument types and parameter sets
• Unwrap parenthesized dot-source operands before scope checks
• Track named blocks until reaching the containing function

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved execution-order and scope-resolution bugs cause incorrect or suppressed alias diagnostics and incorrect formatter replacements across script phases, stored callbacks, DSC assignments, and job initialization.

4 open issues

• Only treat directly invoked script blocks as immediate callbacks · New
• Use the owning script block for phase-order checks · New
• Preserve DSC isolation for script property assignments · New
• Include job initialization declarations in job-body function lookup · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Job-initializer scope handling still rewrites valid initializer-local calls and suppresses expected alias diagnostics when a script-defined function shadows the job command.

2 open issues

• Preserve initializer-local command visibility in job callbacks · New
• Respect script-defined commands shadowing job cmdlets · New

4 resolved since last review

• Include job initialization declarations in job-body function lookup
• Preserve DSC isolation for script property assignments
• Use the owning script block for phase-order checks
• Only treat directly invoked script blocks as immediate callbacks

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The initializer exception misses nested job-body scopes, causing valid calls to initialized functions to be incorrectly rewritten when -ScriptBlock precedes -InitializationScript.

1 open issue

• Initializer exception misses nested calls in job bodies · New

2 resolved since last review

• Respect script-defined commands shadowing job cmdlets
• Preserve initializer-local command visibility in job callbacks

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because unresolved scope and alias-resolution edge cases can cause incorrect formatter replacements, while regression coverage misses a property-name collision.

No open issues 🎉

1 resolved since last review

• Initializer exception misses nested calls in job bodies

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Four unresolved ordering, execution-phase, DSC-context, and unreachable-branch issues cause missed diagnostics or incorrect formatter replacements in AvoidAlias.

4 open issues

• Nested invoked blocks suppress diagnostics for later declarations · New
• Root script phases override invoked block phase ownership · New
• Ordinary function callbacks are misclassified as DSC properties · New
• Unreachable else and elseif declarations suppress diagnostics · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Active scope-resolution defects can suppress valid alias diagnostics for next-line resource bodies and incorrectly flag or rewrite function calls across named execution blocks.

2 open issues

• Use the immediate invocation block to resolve named-block scope · New
• Recognize resource declarations when the opening brace is on the next line · New

4 resolved since last review

• Unreachable else and elseif declarations suppress diagnostics
• Ordinary function callbacks are misclassified as DSC properties
• Root script phases override invoked block phase ownership
• Nested invoked blocks suppress diagnostics for later declarations

_{Review effort: Balanced}

[Copilot]

Fixed in 18fedd1. Named-block phase detection now uses the immediate invocation when available, with a begin/process regression test.

[Copilot]

Fixed in 18fedd1. Following-line resource bodies now resolve back to their declaration for Script-property isolation, with regression coverage.