Repository navigation
Conversation
…ineage entry Tests pinned to one machine (timezone, hardware, APFS case-folding, /private/var, macOS errno, installed tools) now inject or pin their inputs. bin/disclosure-review.mjs uses lib/is-main.mjs and monitor/lockfile.mjs. Two unit tests stop writing .claude/store in the live tree. Inventories, docs/EXIT-CODES.md and docs/REFERENCE.md are brought current. bin/setup.mjs reads a zip pin in-process when tar cannot. package.json files gains codegraph/ and chunk-diff/, which mcp/ and admin/ import.
… children see PATH stubs
… constructor name
…w instead of dropping its observation
# Conflicts: # docs/EXIT-CODES.md # docs/REFERENCE.md
bin/test/no-argv-secrets.test.mjs read a secret written to a child's stdin (lib/update/token.mjs, security -i) as shell interpolation because the template sat on the same line as exec(. Stdin is the remedy the gate itself names; spawn input payloads are now removed before matching, and a control test proves the stdin form passes and the command-string form still fails. monitor/mcp-tools-probe.mjs speak() wrote the three RPC frames with no stdin error handler, so a server that exited before reading crashed the probe with an unhandled EPIPE (CI ubuntu Node 22). EPIPE and ECONNRESET on stdin are now expected; the exit handler gives the verdict. The race did not reproduce locally: the new speak() test guards the exit verdict, not the race.
…s holding unread pipe data On a refusal the helper SIGKILLs bwrap. If bwrap had not yet read the resolv.conf written to fd 5, the helper's socketpair end failed with ECONNRESET, which nothing handled: the helper crashed with exit 1 and a stack, and a caller read the lane as failed instead of not run. This is the intermittent bin/test/sandbox-netns-live.test.mjs:138 failure (1 !== 125) seen on PRs #5 and #8. Pipe errors after a kill are now expected; any other pipe error is a refusal. bin/test/sandbox-net-refusal-pipes.test.mjs reproduces it with a fake bwrap that never reads fd 5: 0/15 before, 15/15 after.
…'s own shutdown deadlock skips instead of failing The stress test's only control allocated objects, which never exercises the background compile that deadlocks at natural exit (nodejs/node#54918, open). macOS CI then failed intermittently on the renderer, which already exits naturally and cannot exit more naturally than a control does. A second control runs hot integer loops over a 1200x630x3 buffer and deflateSync at level 9 with none of the renderer's code. If Node hangs either control, the run skips and names the counts; process.exit() regressions are still caught by the static exitHazards test on every run. Locally (Linux, 2 cores, Node 22.23) both controls hang: 13/24 and 17/24.
macOS Node 26 suite runs take 22-25 minutes; a run on 2026-11-12 was cancelled at the 30-minute limit with every test it had reached passing.
Portll
force-pushed
the
fix/red-ci-20261112
branch
from
November 12, 2026 03:56
6a4bc7c to
019f5c9
Compare
…ode's own shutdown hang skips Under --stress-concurrent-allocation Node can hang any process at natural exit once it has run for a while (nodejs/node#54918, #64274, both open). On 4-core Linux, Node 22.23, a bare setTimeout(2 s) hung 5/24 and a 2 s busy loop 4/24; the old millisecond controls hung none, so they never met the condition and the renderer's hangs were read as its own. The control now spins until its CPU time equals one unstressed renderer run (about 100 ms), so 24 at once stretch it as they stretch the renderer. Five runs: the control hung 1-9/24, the renderer 7-13/24, so the run skips with the counts. Re-executing the renderer with --single-threaded-gc was tried and dropped: the child never hung, but the waiting parent did (7/24).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main has failed on every push since 2026-10-21. On f0ae536, Node 22 fails 39 tests in 22 files on ubuntu and 24 on macOS.
What changes
detectHardwaregains an optionalprobeargument.bin/disclosure-review.mjsuseslib/is-main.mjsand themonitor/lockfile.mjswriter;bin/commit-phase.mjsis back to 6 raw git calls; token-shaped literals in two unit tests are built at run time; the claude-spawn inventory, registry inventory andOPTIONAL_RECORDSare current;schema/wp-weakness-catalogue.schema.jsonis new.docs/EXIT-CODES.md,docs/REFERENCE.md..claude/store.codegraph/andchunk-diff/, whichmcp/server.mjsand threeadmin/modules import.Decisions taken that the owner may reverse
bin/setup.mjsreads a zip pin in-process whentarcannot (GNU tar). Alternative: pin System32 tar on win32.monitor/releases.example.jsonbecomes a twelfth optional record. Alternative: a test exemption.commit-phase.mjsgoes through the file'sgit()wrapper. Alternative: raise the ceiling to 7.Verified
Linux, Node 22.23: the 22 files plus five neighbouring files, 338 tests, 335 pass, 0 fail, 3 skip. Not run: the full suite, macOS, Windows, Node 26.
Not in this change
Three tests that fail on Node 26 only (
daily-run.test.mjs:125,194,unit-memory-store-open-for-read.test.mjs:20) anddocsite-og-image-entry.test.mjs:137on macOS 26.