Repository navigation
Channels found by object class; duplicate-name note across Libraries (#133) - #137
Merged
Merged
Conversation
…133) A driver's channel objects need not be called Subscriber and Publisher (cn=sub, cn=pub). The LDIF reader took such a channel for a container: its policies went into library/ and two drivers' policies of one name became one. Channels are now found by object class; the driver records their names (channel.subscriber / channel.publisher meta, also from a Designer project), and deploy, plan and export-project use them. The duplicate note across Libraries now says the limit is the tree's, not IDM's, and when the copies differ names the drivers that link the copy left out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #133, from klasen's latest run of 0.74.0: every link resolves now, but two points remained.
(a) Channels found by object class.
cn=pub,cn=SAP-HR-XXXandcn=pub,cn=SAP-HR-ZZZeach held apub-ets-ps-Relationships, linked in publisher-event. They look like the drivers' publisher channels under another name; I've asked klasen to confirm the objectClass. The readers knew channels only by the namesPublisher/Subscriber, so 0.74.0 put both policies intolibrary/and kept one: the ZZZ driver's link read XXX's policy.LdifReader(soimport-ldifandimport-live) finds a driver's channels by object class (DirXML-Subscriber/DirXML-Publisher). A name other than the default is kept in driver meta,channel.subscriber/channel.publisher, and written todriver.xml.VaultMapping.channelDn/artifactDn/pathDn/policiesValuestake the driver set and use those names, andPlanpasses the tree. Deploy, plan and new channels for a new driver all use the real DNs.ProjectReaderrecords a Designer channel's name the same way.ProjectWriternames a new driver's channels from it.(c) The duplicate-name note across Libraries. klasen asked why it says "The tree has one Library" when IDM links from any number of Libraries. He's right: it's our tree's limit, not IDM's. The note now says so. When the copies differ, it says that too and names the drivers that link the copy left out, because a deploy that rewrites their links points them at the kept copy. Drivers can be named only when the reader recorded the link DNs (LDIF or vault); a Designer project gets "check the links to it".
Not in this PR: (b), giving each Library its own place in the tree, which needs a design note first.
Tests:
channelsAreFoundByObjectClass: two drivers withcn=pub/cn=subchannels keep their own policies, links resolve, andartifactDn,policiesValuesandchannelDngive back the real DNs.rdnsAreUniqueOnlyInTheirContainerchecks the new note: the content differs, and it names the linking driver.pub/subgives the same tree as the original, plus the two meta entries.🤖 Generated with Claude Code