Skip to content

import-ldif: a second Library inside the driver set, links by DN (#133) - #136

Merged
jcombs-pointblue merged 1 commit into
masterfrom
ldif-library-containers
Nov 18, 2026
Merged

jcombs-pointblue merged 1 commit into
masterfrom
ldif-library-containers

Conversation

@jcombs-pointblue

Copy link
Copy Markdown
Contributor

Follow-up to #135 for #133. klasen's run of 0.73.0 imported the driver set but left 77 links unresolved (ecmascript#3 -> drivers/SKyPRO/SPACDMCS-EcmaScript, publisher-event#0 -> drivers/pub/pub-etp-ValidityPeriodLog, …), and noted two copies of pub-ets-ps-Relationships as if both were in the driver set's Library.

Cause: his driver set holds a second DirXML-Library, cn=SKyPRO,<driver set>. The reader placed objects by the shape of their DN, so SKyPRO read as a driver. Its objects fell back to library/ as the driver set's own, while the links to them were built from the DN as drivers/SKyPRO/…. A deploy would also have written them into cn=Library.

Now:

  • Objects in a DirXML-Library inside the set other than cn=Library, and objects in any container that is no driver or channel, go into library/ as read-only references that keep their DN (library.dn), like other Libraries' objects (Model a driver set that uses Libraries in more than one container #111). A deploy writes links to them with that DN.
  • Links find their target by the DN they name (each artifact's path is recorded by its DN as it is read), so a link and its object always agree. A target the LDIF doesn't hold still falls back to the DN's shape.
  • The unresolved-link warning shows the DN each link names, so whatever remains can be told apart: a target missing from the LDIF, or a container we don't place yet.

Tests: rdnsAreUniqueOnlyInTheirContainer gains a cn=SKyPRO Library with a linked ECMAScript resource and a third pub-ets-ps-Relationships, plus a policy under cn=pub,cn=AD,…. It fails on master; on this branch every link resolves, and policiesValues gives back the original DNs. 1064 tests pass on a clean build. The plain synthetic fixture imports byte for byte as before.

🤖 Generated with Claude Code

A DirXML-Library under the driver set other than cn=Library (cn=SKyPRO) was read
as a driver: its objects went into library/ as the set's own, and links to them
pointed at drivers/SKyPRO/..., which resolve to nothing. Its objects, and those
in any container that is no driver or channel, are now read-only references that
keep their DN; a link finds its target by the DN it names; an unresolved link is
listed with that DN.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jcombs-pointblue
jcombs-pointblue merged commit 56b4521 into master Nov 18, 2026
4 checks passed
@jcombs-pointblue
jcombs-pointblue deleted the ldif-library-containers branch November 18, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant