Repository navigation
import-ldif: a second Library inside the driver set, links by DN (#133) - #136
Merged
Merged
Conversation
A DirXML-Library under the driver set other than cn=Library (cn=SKyPRO) was read as a driver: its objects went into library/ as the set's own, and links to them pointed at drivers/SKyPRO/..., which resolve to nothing. Its objects, and those in any container that is no driver or channel, are now read-only references that keep their DN; a link finds its target by the DN it names; an unresolved link is listed with that DN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #135 for #133. klasen's run of 0.73.0 imported the driver set but left 77 links unresolved (
ecmascript#3 -> drivers/SKyPRO/SPACDMCS-EcmaScript,publisher-event#0 -> drivers/pub/pub-etp-ValidityPeriodLog, …), and noted two copies ofpub-ets-ps-Relationshipsas if both were in the driver set's Library.Cause: his driver set holds a second DirXML-Library,
cn=SKyPRO,<driver set>. The reader placed objects by the shape of their DN, soSKyPROread as a driver. Its objects fell back tolibrary/as the driver set's own, while the links to them were built from the DN asdrivers/SKyPRO/…. A deploy would also have written them intocn=Library.Now:
cn=Library, and objects in any container that is no driver or channel, go intolibrary/as read-only references that keep their DN (library.dn), like other Libraries' objects (Model a driver set that uses Libraries in more than one container #111). A deploy writes links to them with that DN.Tests:
rdnsAreUniqueOnlyInTheirContainergains acn=SKyPROLibrary with a linked ECMAScript resource and a thirdpub-ets-ps-Relationships, plus a policy undercn=pub,cn=AD,…. It fails on master; on this branch every link resolves, andpoliciesValuesgives back the original DNs. 1064 tests pass on a clean build. The plain synthetic fixture imports byte for byte as before.🤖 Generated with Claude Code