Repository navigation
Fix the deadlock - #78
Closed
GamerClassN7 wants to merge 5 commits into
Closed
GamerClassN7 wants to merge 5 commits into
GamerClassN7 wants to merge 5 commits into
Conversation
Refactor set_game and clear_game methods to use replace and take for better handling of previous game data.
Refactor tunnel management by enhancing dead tunnel removal and association handling.
Refactor TunnelMappings struct to include new fields and remove dead tunnels logic.
Merged
Member
|
Reopened as #79 with just the formatter ran and removing the extra .copied() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matchmaking::process_queuelooped forever on the first queued player whose rules didn't match the game (NotMatchnever advanced or removed the entry), while holding the queue mutex. Becauseparking_lotlocks block whole tokio worker threads, every later matchmaking call piled up until the HTTP server and DB pool stopped responding. Separately,SessionData::clear_game/set_gamedroppedSessionGameDatawhile holding the session write lock, and its drop re-acquires that same non-reentrant lock viaremove_player→clear_game_gm, deadlocking the thread on itself. Both are fixed (index-based queue iteration, dropping the old game data after releasing the lock), but not yet tested.