Repository navigation
Fix Markdown Link Check workflow and broken doc links - #28
Merged
Merged
Conversation
setup-node's cache: 'npm' failed every run because the repo has no package-lock.json. Drop the cache, update checkout to v7 and Node to 22, retry on 429s, and run the check when the workflow itself changes. docs/TROUBLESHOOTING.md linked ../../issues, which resolves under /blob/ on GitHub and 404s; use the absolute Issues URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v3.1 was retagged at e82b3b1, which doesn't include this fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- CONTRIBUTING: drop the U+FE0F variation selector from the Commit Message Format heading so GitHub's anchor matches the TOC link. - md-link-check: add a 10-minute job timeout, pin markdown-link-check to 3.15.0, and add .markdown-link-check.json (20s per-link timeout, retry on 429 with a 10s fallback delay, accept 403 from bot-blocking download sites). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
.gitignore ignores *.json, so .markdown-link-check.json never got committed and the job failed with 'Config file not accessible'. Add an exception for it. v3.1 will be retagged to include these fixes, so move their CHANGELOG entries from Unreleased into the 3.1 section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
actions/setup-nodewas set tocache: 'npm', but the repo has nopackage-lock.json, so the setup step fails before any link gets checked.docs/TROUBLESHOOTING.mdlinks to../../issues. On GitHub that resolves under/blob/and returns a 404.#️-commit-message-format, not#-commit-message-format.Changes
md-link-check.yml: removed the npm cache, updatedactions/checkoutv3 → v7 and Node 20 → 22, pinnedmarkdown-link-check@3.15.0, added a 10-minute job timeout, and made the workflow run when its own file or its config changes (plusworkflow_dispatch)..markdown-link-check.json(new; un-ignored in.gitignore, which ignores*.json): 20s per-link timeout, retry on 429 with a 10s fallback delay, and 403 accepted from download sites that block CI runners as bots.docs/TROUBLESHOOTING.md: the Issues link now uses the full URL..github/CONTRIBUTING.md: removed U+FE0F from the heading, so GitHub's anchor matches the TOC link.CHANGELOG.md: listed under 3.1. The v3.1 tag will be moved to this merge commit.Review
Ultrareview found three things: the CONTRIBUTING anchor, no config for bot-blocking hosts, and no job timeout with
--retry. All three are fixed here.Testing
-commit-message-format, which matches the TOC link.🤖 Generated with Claude Code