Repository navigation
✅ test(forge): cover the fail-closed paths in the GitHub, GitLab and message-template code - #204
Merged
Merged
Conversation
…message-template code Restores margin over the 91% coverage floor (D-010/D-128): CI measures 90.6% on main while a local run reads 91.3%, so the gate has been red since the toolchain moved. Adds table tests for error and refusal paths (MergeCAS refusals, snapshot read failures, GitLab approval resolution, message-template edges); local total 92.3%. No production code changed and the threshold is unchanged.
`go-version: stable` rolled to go1.27.2, which raised the stdlib export-data version to 5. golangci-lint v2.13.1 cannot decode it, so `verify` and `release-exitgate` have been red on main since 2026-10-06 and on every PR, with `(typecheck) could not import ... export data version 5 is greater than maximum supported version 4`. Reproduced locally with the go1.27.2 toolchain on PATH and GOTOOLCHAIN=local: v2.13.1 fails on internal/glob; v2.14.0 reports 0 issues on the whole tree and `config verify` passes. Both release binaries say "built with go1.27.0", so D-158's built-with heuristic does not catch a patch-level export-data bump; the env comment now says so.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



CI's coverage gate reads 90.6% against the 91% floor, which has kept
verifyred on main and on every bot PR (#193-#203). This adds tests for refusal and error paths only; no production code and no threshold change. Local total goes from 91.3% to 92.3%.