Repository navigation
Fix TestRareLike spec failing after level requirement change - #10417
Open
lucaskarsten wants to merge 1 commit into
Open
lucaskarsten wants to merge 1 commit into
lucaskarsten wants to merge 1 commit into
Conversation
PathOfBuildingCommunity#10328 removed the hardcoded "Requires Level 48" from That Which Was Taken, since the requirement is now derived from the item's mods. The spec still asserted 48, so busted has failed on dev since that merge. Replace the fixed value with a test that crafts a mod onto the jewel and checks the derived requirement (max of base level and floor(mod level * 0.8)).
lucaskarsten
force-pushed
the
fix/rarelike-test-level
branch
from
November 8, 2026 16:44
78f16bd to
290967a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # . No issue for this.
devCI has been failing since #10328.Description of the problem being solved:
#10328 removed the hardcoded
Requires Level 48from That Which Was Taken, along with the other unique level requirements, because the requirement is now derived from the item's mods.spec/System/TestRareLike_spec.lua:84still asserted48, sobustedhas failed ondevsince that merge. Therun_testsjob fails atTestRareLike_spec.lua @ 80ondev(3dbca44) and on PRs opened since then, for example the runs onbugfix/polaric-devastationandfeature/abyss-node-lines.This PR removes the fixed assertion and adds a test for the derived requirement instead. The test crafts
AnimalCharmMaximumRage2onto the jewel and checks that the level requirement ismax(base level, floor(mod level * 0.8)). For that mod this gives 48 (level 60 mod), the value the old line had.Only the spec changes. No source or data files are touched.
Steps taken to verify a working solution:
busted --lua=luajitwithCI=truein thepathofbuilding-testsimage ondev(3dbca44): 666 successes / 1 failure before, 668 successes / 0 failures after.0.8factor inItem.luato0.7and confirmed the new test fails (expected 48, got 42).ModJewelCharm.luamatch the current game data (238/238).Link to a build that showcases this PR:
N/A (test only)
Before screenshot:
N/A
After screenshot:
N/A