Repository navigation
Allow concurrent authentication reads without weakening credential locks - #74
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec276767fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
44f90e8 to
6ef63cf
Compare
Authenticated requests previously took an exclusive owner lock, serializing unrelated reads. Safe HTTP requests now use a shared owner lock; mutation requests acquire the exclusive lock before reading credentials, so concurrent uploads cannot deadlock while upgrading locks. Credential changes still wait for active reads to finish.
The PostgreSQL regressions prove that two reads overlap, credential changes wait for both reads, and two authenticated mutations serialize without a lock-upgrade deadlock. Also fixes the reviewed block spacing in background-task creation.
Validation: all 589 backend tests passed (2 external provider smoke tests deselected), including 54 focused authentication, verification and user tests; Ruff, formatting and Mypy passed. The acquisition fixture commits setup before crossing into its authenticated HTTP request.
Closes #73.