Skip to content

Restore the saved PDF page when reopening without a locator - #30

Merged
Eoic merged 1 commit into
developmentfrom
fix/restore-saved-pdf-page
Nov 13, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/restore-saved-pdf-page

Conversation

@Eoic

@Eoic Eoic commented Nov 13, 2026

Copy link
Copy Markdown
Member

When reopening with a saved PDF view but no explicit locator, the engine previously selected page 1 and discarded the saved center. It now uses the saved page as its bounded fallback; an explicit locator still takes precedence.

Validation: 41 PDF engine/tool tests pass, including actual PDF viewport checks for saved page/center/zoom and explicit location precedence. Reader and example analysis/format checks pass.

Closes #29. Addresses the release review in #28.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 01:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T01:39:56.798000Z 2456b81 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic merged commit 3dbe76b into development Nov 13, 2026
4 checks passed
@Eoic
Eoic deleted the fix/restore-saved-pdf-page branch November 13, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore the persisted PDF page when reopening without an explicit locator

2 participants