Skip to content

Paginate metadata search and polish book editing and covers - #154

Merged
Eoic merged 1 commit into
developmentfrom
feature/metadata-search-polish
Nov 14, 2026
Merged

Eoic merged 1 commit into
developmentfrom
feature/metadata-search-polish

Conversation

@Eoic

@Eoic Eoic commented Nov 14, 2026

Copy link
Copy Markdown
Member

Metadata search now supports Previous/Next pages for Open Library and Google Books instead of stopping after ten results. Failed page loads preserve the current results for retry, while new searches and disposal ignore stale responses. Google Books uses the selected Papyrus server with token refresh and profile-switch guards.

Book editing also gains the requested refinements:

  • Move metadata source selection to Settings > Library using the standard settings card.
  • Render public covers without CORS headers in search results, previews and shared book covers; add a real Chrome regression to CI.
  • Use consistent centered shadows for book cards, acquisition placeholders, metadata results and details/edit covers, respecting e-ink themes.
  • Tighten spacing above form headings, move the ripple-free Physical book switch below rating, and remove the redundant apply hint and metadata/save success snackbars.

Closes #153. Contributes to FR-2_13 (PapyrusReader/docs#15), FR-2_2 (PapyrusReader/docs#17), and FR-2_14 (PapyrusReader/docs#16); these requirements are not marked fully verified by this scoped change.

Dependency: deploy PapyrusReader/server#77 with its Google Books key before releasing this client. Open Library remains direct. No version or reader dependency change is included.

Validation:

  • Final focused client run: 171 passing tests covering metadata services, pagination, profile isolation, responsive forms/settings, physical-book entry and cover/card behavior.
  • Chrome no-CORS cover regression: 2 passing tests, including edit preview.
  • tools/papyrus check client: formatting, analyzer and all 22 web/bootstrap checks pass.
  • Earlier in this workstream: full client suite 2,346 passed / 19 skipped and release web build passed; final small UI changes were checked by focused tests and hot reload.
  • Local checks used the existing reader path override, which remains uncommitted; CI validates the committed dependency lock. Physical-device acceptance has not been repeated.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 23:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T23:22:44.254829Z 07f2a55 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic enabled auto-merge November 14, 2026 23:22
@Eoic
Eoic merged commit a947a60 into development Nov 14, 2026
9 checks passed
@Eoic
Eoic deleted the feature/metadata-search-polish branch November 14, 2026 23:32
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.82700% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/lib/services/metadata_service.dart 90.47% 6 Missing ⚠️
app/lib/widgets/book/private_book_cover.dart 0.00% 5 Missing ⚠️
app/lib/main.dart 85.00% 3 Missing ⚠️
app/lib/providers/book_edit_provider.dart 96.36% 2 Missing ⚠️
app/lib/themes/card_shadow.dart 91.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paginate metadata search and polish book editing and covers

2 participants