Repository navigation
Keep reader theme checks independent of appearance controls - #152
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The host-theme contrast test tried to tap Light/Night chips directly, so it failed when the reader's appearance control became a dropdown. Apply the appearance through ReaderController, then retain the existing contrast and e-ink assertions on the client-owned settings route. Reader tests cover selecting the preset control itself.
Closes #151. Final-review follow-up for PapyrusReader/reader#33; relates to FR-3_1 (PapyrusReader/docs#25).
Validation: all 48 targeted reader integration tests passed with the local reader changes; all 12 theme combinations also passed against the unchanged Git-pinned reader. Client formatting/analysis and 22 web checks passed. The ignored local reader override and its lockfile state were restored. No dependency pins or production code change.