Skip to content

Keep reader theme checks independent of appearance controls - #152

Merged
Eoic merged 1 commit into
developmentfrom
test/reader-appearance-theme
Nov 14, 2026
Merged

Eoic merged 1 commit into
developmentfrom
test/reader-appearance-theme

Conversation

@Eoic

@Eoic Eoic commented Nov 14, 2026

Copy link
Copy Markdown
Member

The host-theme contrast test tried to tap Light/Night chips directly, so it failed when the reader's appearance control became a dropdown. Apply the appearance through ReaderController, then retain the existing contrast and e-ink assertions on the client-owned settings route. Reader tests cover selecting the preset control itself.

Closes #151. Final-review follow-up for PapyrusReader/reader#33; relates to FR-3_1 (PapyrusReader/docs#25).

Validation: all 48 targeted reader integration tests passed with the local reader changes; all 12 theme combinations also passed against the unchanged Git-pinned reader. Client formatting/analysis and 22 web checks passed. The ignored local reader override and its lockfile state were restored. No dependency pins or production code change.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 19:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T19:16:58.392088Z 8670308 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Eoic
Eoic merged commit 32c3a01 into development Nov 14, 2026
7 checks passed
@Eoic
Eoic deleted the test/reader-appearance-theme branch November 14, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple reader theme contrast regression from appearance chips

2 participants