Repository navigation
fix: align mobile annotation scrollbar with quote viewport - #150
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Issue and requirements
Closes #149. Supports FR-4_1 (text highlighting) and FR-4_3 (annotation editing) in the functional requirements.
Summary
On phones, the highlighted passage could reach its end while the scrollbar thumb stopped short. The embedded scrollbar inherited the screen's bottom navigation inset. Remove that padding locally around the quote pane so the thumb reaches the viewport edge while the footer keeps its safe-area spacing.
Extend the existing regression to swipe through wrapped text and check the painted thumb's bottom edge, unchanged note position, safe footer position, and saved passage. The test fails before the fix with a 48-pixel navigation inset.
Testing
tools/papyrus test client -- test/widgets/book_details/annotation_dialog_test.dart test/widgets/shared/bottom_sheet_layouts_test.dart: 24 passed. The six annotation tests also passed after the final footer assertion was added.tools/papyrus check client: formatting, analyzer, and 22 JavaScript checks passed.UI evidence
Native emulator inspection used a dark-theme annotation preview with bold, wrapped text and the final marker
END OF HIGHLIGHT.. The marker was fully visible and the thumb aligned with the quote pane's bottom edge. Widget coverage additionally checks a 48-pixel phone navigation inset and a desktop viewport.Compatibility and migration
No migrations or public API changes.
Notes
Local checks used the existing reader path override. The override and its lockfile changes are excluded. Physical-phone and iOS verification have not been run. CI results are pending.
Checklist