Skip to content

fix: align mobile annotation scrollbar with quote viewport - #150

Merged
Eoic merged 2 commits into
developmentfrom
fix/149-annotation-scrollbar-inset
Nov 14, 2026
Merged

Eoic merged 2 commits into
developmentfrom
fix/149-annotation-scrollbar-inset

Conversation

@Eoic

@Eoic Eoic commented Nov 13, 2026

Copy link
Copy Markdown
Member

Issue and requirements

Closes #149. Supports FR-4_1 (text highlighting) and FR-4_3 (annotation editing) in the functional requirements.

Summary

On phones, the highlighted passage could reach its end while the scrollbar thumb stopped short. The embedded scrollbar inherited the screen's bottom navigation inset. Remove that padding locally around the quote pane so the thumb reaches the viewport edge while the footer keeps its safe-area spacing.

Extend the existing regression to swipe through wrapped text and check the painted thumb's bottom edge, unchanged note position, safe footer position, and saved passage. The test fails before the fix with a 48-pixel navigation inset.

Testing

  • tools/papyrus test client -- test/widgets/book_details/annotation_dialog_test.dart test/widgets/shared/bottom_sheet_layouts_test.dart: 24 passed. The six annotation tests also passed after the final footer assertion was added.
  • tools/papyrus check client: formatting, analyzer, and 22 JavaScript checks passed.
  • Android direct debug build passed; web hot reload succeeded.
  • Android 16 emulator: repeatedly swipe a long captured quote upward. Verified the final line and thumb reach the bottom together; scroll offset reached 1016 / 1016. Full Papyrus app subsequently launched successfully.

UI evidence

Native emulator inspection used a dark-theme annotation preview with bold, wrapped text and the final marker END OF HIGHLIGHT.. The marker was fully visible and the thumb aligned with the quote pane's bottom edge. Widget coverage additionally checks a 48-pixel phone navigation inset and a desktop viewport.

Compatibility and migration

No migrations or public API changes.

Notes

Local checks used the existing reader path override. The override and its lockfile changes are excluded. Physical-phone and iOS verification have not been run. CI results are pending.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the agreed scope.
  • Relevant tests have been added or updated.
  • Formatting, analysis, and tests pass locally.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 23:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T23:35:17.012269Z abdfb42 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Eoic
Eoic enabled auto-merge November 14, 2026 20:53
@Eoic
Eoic merged commit 488d5a7 into development Nov 14, 2026
6 checks passed
@Eoic
Eoic deleted the fix/149-annotation-scrollbar-inset branch November 14, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotation quote scrollbar stops short on mobile

2 participants