Skip to content

Keep logout and late request failures isolated from newer sessions - #147

Merged
Eoic merged 1 commit into
developmentfrom
fix/release-authentication-races
Nov 13, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/release-authentication-races

Conversation

@Eoic

@Eoic Eoic commented Nov 13, 2026

Copy link
Copy Markdown
Member

Logout now starts clearing the captured repository's credentials independently of the preferences write, so switching servers cannot abandon cleanup and signing in again cannot be cleared by delayed cleanup. Authorization failures update provider state only if they belong to its current authentication operation.

Also pins reader 2456b81131f83b802115066cdf65be6ac73d4699 to restore the saved PDF page when reopening without an explicit locator.

Validation: 88 focused authentication and reader integration tests pass; client analysis, formatting and 22 browser-support JS tests pass. Regressions cover a delayed preference write followed by switching servers or signing in again, and an old request returning 401 after a new sign-in.

Closes #146. Addresses release-review findings in #145; reader dependency: reader #30.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 01:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T01:41:06.255058Z 6782d37 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Eoic
Eoic merged commit 3fbd54d into development Nov 13, 2026
10 checks passed
@Eoic
Eoic deleted the fix/release-authentication-races branch November 13, 2026 01:52
@Eoic Eoic mentioned this pull request Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve session isolation during logout and late authorization failures

2 participants