Repository navigation
Keep logout and late request failures isolated from newer sessions - #147
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Logout now starts clearing the captured repository's credentials independently of the preferences write, so switching servers cannot abandon cleanup and signing in again cannot be cleared by delayed cleanup. Authorization failures update provider state only if they belong to its current authentication operation.
Also pins reader 2456b81131f83b802115066cdf65be6ac73d4699 to restore the saved PDF page when reopening without an explicit locator.
Validation: 88 focused authentication and reader integration tests pass; client analysis, formatting and 22 browser-support JS tests pass. Regressions cover a delayed preference write followed by switching servers or signing in again, and an old request returning 401 after a new sign-in.
Closes #146. Addresses release-review findings in #145; reader dependency: reader #30.