Repository navigation
Conversation
The product layout's breadcrumb linked to /products, the only extensionless internal link on the site. The products collection is written to /products/*.html, so /products is also a directory with no index page. Under the repo's nginx config the link redirects to /products/ and returns 403. Point it at /products.html, matching the "All Products" link in the same layout and the header and footer navigation. html-proofer did not flag this because the directory exists on disk. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Michael Harp <mike@mikeharp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: this only affects the site when it runs from the container image (for example a local
docker runpreview). The live GitHub Pages site is not affected.The "Products" breadcrumb on every product page links to
/products. GitHub Pages resolves that toproducts.html, so it works in production. The repo's nginx container does not, so the same click returns a 403 there. This points the breadcrumb at/products.html, which works in both.The problem
_layouts/product.htmlwas the only place on the site with an extensionless internal link. The products collection is written to/products/*.html, so/productsis also a directory, and that directory has no index page./products/products/, then 403/products.htmlhtml-proofer did not catch this because the
productsdirectory exists in the built site.The fix
One line: the breadcrumb now uses
/products.html, the same target as the "All Products" button in the same layout and the header and footer links.Testing
nginxinc/nginx-unprivileged:alpineand the repo'snginx.conf.https://openvoxproject.github.io/productsreturns 200 today, so nothing changes for the live site.htmlprooferpasses on the rebuilt site, and no extensionless internal links remain in the output.Assisted by Claude.