Repository navigation
fix: use module selectors in observation macro expansion - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid ambiguous observation macros when OpenObservation and Apple's Observation are visible in the same file, including through UIKit or AppKit.
Changes
OpenObservation::attributes and recognize unqualified names, dot-qualified names, and module selectors.Toolchain and CI
Require Swift 6.3 for module selector support. Update macOS and Ubuntu CI to Swift 6.3.3 and run macro tests in both workflows.
Ignore generated Xcode projects and Derived directories.
Validation